Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors on older clang versions (Wextra-semi-stmt, Wsign-conversion) #749

Open
michael-dwan opened this issue Sep 6, 2024 · 1 comment · May be fixed by #750
Open

Build errors on older clang versions (Wextra-semi-stmt, Wsign-conversion) #749

michael-dwan opened this issue Sep 6, 2024 · 1 comment · May be fixed by #750

Comments

@michael-dwan
Copy link

michael-dwan commented Sep 6, 2024

Hello, I ran into an admittedly probably small-reaching issue. I'm working on a project on a much older macOS, and have a few versions of clang (AppleClang 13.0.0, and several version of clang 15.0.x from upstream.)

AppleClang 13 seems fine, but, on a couple of the 15.0.x version (15.0.7 for instance), using EXEC_TIME functionality leads to errors from the warnings:

  • -Wextra-semi-stmt
  • -Wsign-conversion

I've forked the repo to fix it for myself, but, the changes seemed localized enough that I thought I'd see if there was any interest in a pull-request, recognizing that it's probably not an issue for most users.

Change can be previewed here: master...michael-dwan:Unity:fix/Issue-749_build_errors_in_older_clangs

@mvandervoord
Copy link
Member

A PR would be much appreciated, actually! That's a good thing to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants