Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown plugin does not work with links with ' #3108

Closed
ghost opened this issue Feb 5, 2018 · 21 comments · Fixed by #3876
Closed

markdown plugin does not work with links with ' #3108

ghost opened this issue Feb 5, 2018 · 21 comments · Fixed by #3876

Comments

@ghost
Copy link

ghost commented Feb 5, 2018

Something like [foo](It's about me) does not work. And this [foo](It about me) does

@pmario
Copy link
Member

pmario commented Feb 5, 2018

@sukima
Copy link
Contributor

sukima commented Feb 5, 2018

The problem is that [foo](It's about me) is not valid markdown. In fact neither is [foo](It about me) which seem just coincidence that it works because I would not expect it to.

The part inside the parentheses needs to be a URL and URLs do not have spaces. Perhaps something like this: [foo](#It's%20about%20me) would work?

@ghost
Copy link
Author

ghost commented Feb 7, 2018

Let's be clear:

  • Create a tiddler called It's time which has a permalink https://tiddlywiki.com/#It's%20time
  • How to link to it from markdown tiddlers? With [foo](#It's%20time)
  • It does not work because the link has '

@sukima
Copy link
Contributor

sukima commented Feb 7, 2018

@somenxavier Thank you for the clarification. This is indeed a bug:

screenshot

I can also confirm this is not a bug with TiddlyWiki but a bug with the markdown parser we use as evident by this JSBin.

Oh and @somenxavier you have already submitted a bug report.

@ghost
Copy link
Author

ghost commented Feb 8, 2018

@sukima thanks for confirming the bug. We are dependent of that bug report of markdown parser so. I did not remember that. I hope this will get solved fast

@ghost
Copy link
Author

ghost commented Feb 8, 2018

Perhaps we could move to https://github.com/markdown-it/markdown-it

@pmario
Copy link
Member

pmario commented Feb 9, 2018

You can try markdown-it with TW at: https://wikilabs.github.io/editions/markdown-it/#HelloThere

@ghost
Copy link
Author

ghost commented Feb 9, 2018

@pmario : Can I install it and remove the markdown official plugin? After drag and drop I cannot use it. It does not appear in plugins list.

@pmario
Copy link
Member

pmario commented Feb 9, 2018

Can I install it and remove the markdown official plugin?

Yea first remove the other plugin.
Download an empty.html and try again

@ghost
Copy link
Author

ghost commented Feb 13, 2018

@pmario How can I do this exactly: remove old plugin and install new plugin?

@ghost
Copy link
Author

ghost commented Feb 18, 2018

@pmario Perhaps tiddlywiki could remove markdown-official-plugin and put it markdown-it as official, couldn't?

@ghost
Copy link
Author

ghost commented Feb 20, 2018

Can I install it and remove the markdown official plugin?

Yea first remove the other plugin.
Download an empty.html and try again

It doesn't work: no +Markdown button, and no "Markdown" in type after applying to empty.html. Please try it:

  1. Download empty.html
  2. Install your plugin
  3. You cannot add a markdown page

@pmario
Copy link
Member

pmario commented Feb 21, 2018

I did just test it. It seems to work for me. ... Did you save and reload the TW, after importing the plugin.

  • I did open the ControlPanel: Plugins tab
  • Opened a second window with empty.html
  • dragged the md plugin onto empty.
  • import
  • save
  • reload

@ghost
Copy link
Author

ghost commented Feb 25, 2018

I did just test it. It seems to work for me. ... Did you save and reload the TW, after importing the plugin.

I did open the ControlPanel: Plugins tab
Opened a second window with empty.html
dragged the md plugin onto empty.
import
save
reload

Do you do that in tiddlydesktop? In firefox it does not run because Apocalypse

@pmario
Copy link
Member

pmario commented Feb 25, 2018

Do you do that in tiddlydesktop? In firefox it does not run because Apocalypse

I use FireFox 99% of the time. V58.0.2 atm

@ghost
Copy link
Author

ghost commented Feb 26, 2018

In firefox I can't get that it saves me tiddlywiki empty changes: v 58.0.2 also: change title in GettingStarted -> save button -> dialog of "save as" -> cancel -> reload -> the same title again

@pmario
Copy link
Member

pmario commented Feb 26, 2018

In firefox I can't get that it saves me tiddlywiki empty changes: v 58.0.2 also: change title in GettingStarted -> save button -> dialog of "save as" -> cancel -> reload -> the same title again

hmmm, If you "cancel" the save request, why should it save something?

It needs to be: save button -> dialog "save as" -> overwrite existing empty.html -> reload (optional)

If you want to skip the "save as" dialog, you could use my FF browser plugin file-backups, which will overwrite existing files .... BUT be aware modern browsers only let us save to the browser Downloads directory and subdirectories. ....

@ghost
Copy link
Author

ghost commented Feb 27, 2018

Now I install this plugin (see shot) but I can't use Markdown in types
captura de pantalla_2018-02-27_17-19-20
captura de pantalla_2018-02-27_17-18-26

@pmario
Copy link
Member

pmario commented Feb 27, 2018

hmmm, That's strange. ... What does ControlPanel: Plugins Tab show?

@ghost
Copy link
Author

ghost commented Feb 28, 2018

captura de pantalla_2018-02-28_15-03-21
It does not appear in Plugins Tab

@ghost
Copy link
Author

ghost commented Feb 28, 2018

I think we could issue this as a separate issue: #3141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants