From 4e834ef29e17ea35f43a7e25645506a561b33715 Mon Sep 17 00:00:00 2001
From: Nicola Lanzilotto <nicola@tiledesk.com>
Date: Mon, 23 Sep 2024 14:40:39 +0200
Subject: [PATCH] Minor improvements

---
 .../modal-faqs/modal-faqs.component.scss      |  4 ++--
 ...odal-preview-knowledge-base.component.html | 14 ++++++++----
 .../modal-preview-knowledge-base.component.ts | 13 ++++++++---
 .../modal-urls-knowledge-base.component.html  | 22 +++++++------------
 4 files changed, 30 insertions(+), 23 deletions(-)

diff --git a/src/app/knowledge-bases/modals/modal-faqs/modal-faqs.component.scss b/src/app/knowledge-bases/modals/modal-faqs/modal-faqs.component.scss
index 5f982c22dd9f..46c2c1914ecf 100644
--- a/src/app/knowledge-bases/modals/modal-faqs/modal-faqs.component.scss
+++ b/src/app/knowledge-bases/modals/modal-faqs/modal-faqs.component.scss
@@ -460,8 +460,8 @@
     // margin: 100px auto;
     // margin: 80px auto;
     margin: 75.01px auto;
-    width: 40px;
-    height: 40px;
+    width: 41px;
+    height: 41px;
     // width: 100px;
     // height: 100px;
     position: relative;
diff --git a/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.html b/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.html
index e0400090fca0..11b4722c8aa2 100644
--- a/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.html
+++ b/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.html
@@ -41,7 +41,9 @@ <h1 mat-dialog-title> {{ 'Preview' | translate }} </h1>
 
   <div *ngIf="show_answer" class="form--container" style="margin-bottom: 0px;">
     <p *ngIf="answer" class="answer-title">
-      {{ 'KbPage.Answer' | translate }} <span> ({{ 'KbPage.GeneratedByModel' | translate: {ai_model_name: qa?.ai_model } }}) </span>
+      {{ 'KbPage.Answer' | translate }} 
+      
+      <span *ngIf="qa?.ai_model"> ({{ 'KbPage.GeneratedByModel' | translate: {ai_model_name: qa?.ai_model } }}) </span>
     </p>
     <div id="answer" class="answer">
       
@@ -66,7 +68,7 @@ <h1 mat-dialog-title> {{ 'Preview' | translate }} </h1>
     <hr class="horizontal-line" *ngIf="qa && qa.source">
 
     <p *ngIf="qa && qa.source" class="answer-title">{{ 'KbPage.Source' | translate }}</p>
-    <div id="answer" class="answer">
+    <div *ngIf="qa && qa.source" id="answer" class="answer">
       <span *ngIf="qa && qa.source">{{ 'KbPage.Source' | translate }}:
         <a *ngIf="source_url" href="{{source_url}}" target="_blank">{{ source_url }}</a>
         <span *ngIf="!source_url">{{ qa.source }}</span>
@@ -75,11 +77,15 @@ <h1 mat-dialog-title> {{ 'Preview' | translate }} </h1>
     </div>
     <label *ngIf="!aiQuotaExceeded" class="control-label response-time-label">
       <!-- {{ 'KbPage.LabelResponseTime' | translate: translateparam }} -->
-      {{ 'Analytics.Metrics.ResponseTime' | translate }}: <span> {{ 'KbPage.AIResponseTime' | translate: translateparam }} </span>
+      <span *ngIf="responseTime"> 
+        {{ 'Analytics.Metrics.ResponseTime' | translate }}: <span> {{ 'KbPage.AIResponseTime' | translate: translateparam }} </span>
+      </span>
     </label>
     <label *ngIf="!aiQuotaExceeded" class="control-label prompt-size-label">
       <!-- {{ 'KbPage.TotalTokensUsage' | translate: {prompt_token_size: prompt_token_size } }} -->
-      {{ 'KbPage.PromptSize' | translate }}: <span> {{ 'KbPage.PromptSizeUsage' | translate: {prompt_token_size: prompt_token_size } }} </span>
+      <span *ngIf="prompt_token_size"> 
+        {{ 'KbPage.PromptSize' | translate }}: <span> {{ 'KbPage.PromptSizeUsage' | translate: {prompt_token_size: prompt_token_size } }} </span>
+      </span>
     </label>
   </div>
 
diff --git a/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.ts b/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.ts
index cc96b0203fae..4ad1115727fe 100644
--- a/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.ts
+++ b/src/app/knowledge-bases/modals/modal-preview-knowledge-base/modal-preview-knowledge-base.component.ts
@@ -256,7 +256,7 @@ export class ModalPreviewKnowledgeBaseComponent extends PricingBaseComponent imp
       this.prompt_token_size = response.prompt_token_size;
       this.logger.log("[MODAL-PREVIEW-KB] ask gpt preview prompt_token_size: ", this.prompt_token_size)
       const endTime = performance.now();
-      this.responseTime = Math.round((endTime - startTime) / 1000);
+      this.responseTime = Math.round((endTime - startTime) / 1000); 
       this.translateparam = { respTime: this.responseTime };
       this.qa = response;
       this.logger.log("[MODAL-PREVIEW-KB] ask gpt preview qa: ", this.qa)
@@ -277,14 +277,21 @@ export class ModalPreviewKnowledgeBaseComponent extends PricingBaseComponent imp
       this.show_answer = true;
       this.searching = false;
     }, (err) => {
-      // this.logger.log("ask gpt preview response error: ", err);
+      this.logger.log("ask gpt preview response error: ", err);
       // this.logger.log("ask gpt preview response error message: ", error.message);
       // this.logger.log("ask gpt preview response error error: ", error.error);
       if (err && err.error && err.error.error_code === 13001) {
         this.answer = this.translate.instant('KbPage.AiQuotaExceeded')
         this.aiQuotaExceeded = true
-      } else {
+      } else if (err && err.error && err.error.message) {
         this.answer = err.error.message;
+      } else if (err.error && err.error.error && err.error.error.answer)  {
+        this.answer = err.error.error.answer;
+        // && err.headers.statusText
+        if (err.statusText) {
+          this.logger.log("ask gpt preview  error h1 err.headers ", err.statusText);
+          this.answer = this.answer + ' (' + err.statusText + ')'
+        }
       }
 
       this.logger.error("ERROR ask gpt: ", err.message);
diff --git a/src/app/knowledge-bases/modals/modal-urls-knowledge-base/modal-urls-knowledge-base.component.html b/src/app/knowledge-bases/modals/modal-urls-knowledge-base/modal-urls-knowledge-base.component.html
index 548a65b1f936..a07fd63e7e8c 100644
--- a/src/app/knowledge-bases/modals/modal-urls-knowledge-base/modal-urls-knowledge-base.component.html
+++ b/src/app/knowledge-bases/modals/modal-urls-knowledge-base/modal-urls-knowledge-base.component.html
@@ -11,23 +11,17 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
         </div>
     </div>
 
-    <mat-accordion>
+    <!-- <mat-accordion>
         <mat-expansion-panel (opened)="panelOpenState = true" (closed)="panelOpenState = false" class="custom-expansion-panel">
             <mat-expansion-panel-header class="disable_ripple">
                 <mat-panel-title> Advanced Options </mat-panel-title>
             </mat-expansion-panel-header>
             <div class="expansion-panel-content">
-                <!-- SCRAPE TYPE -->
+                <!- - SCRAPE TYPE - ->
                 <div class="option-box">
                     <div style="display: flex; flex-direction: column; align-items: flex-start;">
                         <span class="input-label">Indexing type</span>
-                        <!-- <mat-form-field appearance="outline">
-                            <mat-select [(ngModel)]="selectedScrapeType" disableOptionCentering>
-                                <mat-option *ngFor="let type of scrape_types" [value]="type.value">
-                                    {{type.name}}
-                                </mat-option>
-                            </mat-select>
-                        </mat-form-field> -->
+                       
                         <ng-select class="custom-ng-select" style="min-width: 200px; margin-bottom: 6px;" appendTo="body" [items]="scrape_types" bindLabel="name" bindValue="value"
                             placeholder="{{ 'KbPage.PlaceholderSelectEngine' | translate }}" [clearable]="false"
                             [searchable]="false" [(ngModel)]="selectedScrapeType" (change)="onSelectScrapeType(selectedScrapeType)">
@@ -39,7 +33,7 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
                 </div>
                 <div *ngIf="selectedScrapeType === 4" class="option-box" style="width: 100%; margin-left: 12px;">
 
-                    <!-- TAGS TO EXTRACT -->
+                    <!- - TAGS TO EXTRACT - ->
                     <div style="display: flex; flex-direction: column; align-items: flex-start;">
                         <span class="input-label">Extract Tags (Mandatory)</span>
                         <mat-form-field class="chip-list" appearance="outline" style="width: 95%; font-size: 13px;">
@@ -52,7 +46,7 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
                                     <button matChipRemove>
                                         <mat-icon>cancel</mat-icon>
                                     </button>
-                                    <!-- <mat-icon matChipRemove *ngIf="removable">cancel</mat-icon> -->
+                                    <!- - <mat-icon matChipRemove *ngIf="removable">cancel</mat-icon> - ->
                                 </mat-chip>
                                 <input style="font-size: 13px; background-color: white; border: none;" [matChipInputFor]="extractTags" placeholder="Type and press Enter"
                                     [matChipInputSeparatorKeyCodes]="separatorKeysCodes" (matChipInputTokenEnd)="addTag('extract_tags', $event)">
@@ -60,7 +54,7 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
                         </mat-form-field>
                     </div>
 
-                    <!-- UNWANTED TAGS -->
+                    <!- - UNWANTED TAGS - ->
                     <div style="display: flex; flex-direction: column; align-items: flex-start;">
                         <span class="input-label">Unwanted Tags</span>
                         <mat-form-field class="chip-list" appearance="outline" style="width: 95%; font-size: 13px;">
@@ -78,7 +72,7 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
                         </mat-form-field>
                     </div>
 
-                    <!-- UNWANTED CLASSNAMES -->
+                    <!- - UNWANTED CLASSNAMES - ->
                     <div style="display: flex; flex-direction: column; align-items: flex-start;">
                         <span class="input-label">Unwanted Classnames</span>
                         <mat-form-field class="chip-list" appearance="outline" style="width: 95%; font-size: 13px;">
@@ -99,7 +93,7 @@ <h1 mat-dialog-title style="font-family: 'Poppins';">  {{ 'KbPage.titleUrls' | t
                 </div>
             </div>
         </mat-expansion-panel>
-    </mat-accordion>
+    </mat-accordion> -->
 
     <div class="form-container">
         <!-- <form [formGroup]="kbForm"> -->