-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Label Smoothing #55
Comments
Yes, you are correct — thank you for reporting this! I will need to study if the results change only slightly or significantly. If the difference is only slightly I will introduce it directly into the codebase. If the difference is significant, I will need to build some workaround. |
With the fixed label smoothing, one needs much higher label smoothing values to get a good score. Here the results of my grid search. The mean metric value is the Mean Reciprocal Rank (MRR). WN18RR Bugged
WN18RR Fixed
FB15k-237 Bugged
FB15k-237 Fixed
As such it would would distort the results if I just change this blindly. I will think about a solution. Probably I will make an extra parameter where one can run with correct label smoothing. |
I think that the correct way should be |
Hi @lvermue , I think the equation still has some problem. As each position in
|
I read from line 141 in main.py about label smoothing:
Isn't it should be the following instead?
The text was updated successfully, but these errors were encountered: