You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The framework currently requires UIModalPresentationStyle.fullScreen. However, can (and does) break some apps that use custom view controller presentation. We had to rework (and degrade) the navigation of our app to work with TOCropViewController.
With UIModalPresentationStyle.fullScreen, UIKit removes the presenting view controller's view from the view hierarchy. On dismissal, UIKit reinstalls the presenting view controller's view. However, this process is not robust when the presenting view controller itself is presented using a custom presentation.
In my specific case, we're using custom view controller presentation provided by SwiftMessages to display the presenting view controller. When TOCropViewController is dismissed, the presenting view controller's view is no longer visible because UIKit didn't properly restore the custom presentation's view hierarchy.
Describe the solution you'd like
Potential solutions in order of preference:
Support all modal presentation styles
Support UIModalPresentationStyle.overFullScreen
Change from UIModalPresentationStyle.fullScreen to UIModalPresentationStyle.overFullScreen
Describe alternatives you've considered
We had to deviate from our app's navigation paradigm and use standard modal presentation with the flow that involves TOCropViewController.
The text was updated successfully, but these errors were encountered:
See my response here because it is indeed possible to do what you want to do here. Not sure if it was possible when this was posted, but it is possible now. 👍🏼
Is your feature request related to a problem? Please describe.
The framework currently requires
UIModalPresentationStyle.fullScreen
. However, can (and does) break some apps that use custom view controller presentation. We had to rework (and degrade) the navigation of our app to work withTOCropViewController
.With
UIModalPresentationStyle.fullScreen
, UIKit removes the presenting view controller's view from the view hierarchy. On dismissal, UIKit reinstalls the presenting view controller's view. However, this process is not robust when the presenting view controller itself is presented using a custom presentation.In my specific case, we're using custom view controller presentation provided by SwiftMessages to display the presenting view controller. When
TOCropViewController
is dismissed, the presenting view controller's view is no longer visible because UIKit didn't properly restore the custom presentation's view hierarchy.Describe the solution you'd like
Potential solutions in order of preference:
UIModalPresentationStyle.overFullScreen
UIModalPresentationStyle.fullScreen
toUIModalPresentationStyle.overFullScreen
Describe alternatives you've considered
We had to deviate from our app's navigation paradigm and use standard modal presentation with the flow that involves
TOCropViewController
.The text was updated successfully, but these errors were encountered: