Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any tips for rebuilding noble-winrt? #14

Closed
ELundby45 opened this issue Dec 4, 2018 · 4 comments
Closed

Any tips for rebuilding noble-winrt? #14

ELundby45 opened this issue Dec 4, 2018 · 4 comments

Comments

@ELundby45
Copy link

Thank you and Timeular for working on noble-winrt, I'm very hopeful this gets merged into noble soon.

I'm facing similar struggles to issue #11, with the exception that I'm trying to build for nw.js. Rather than having you specify every possible version of electron and nw.js in appveyor, do you have any tips for the correct dev setup for building noble-winrt?

I have Visual Studio 2017 installed along with all of the build tools but am facing tons of errors when trying to rebuild (most along the lines of \noble-winrt\src\napi_winrt.h(7): error C2065: 'UUID': undeclared identifier)

I've tried running:

  • prebuild -t 0.34.5 -r node-webkit
  • nw-gyp rebuild --target=0.34.5 --arch=ia32
  • node-gyp rebuild
  • prebuild -t 6.14.4 -t 8.12.0 -r node

All producing the same errors (error_log.log)

@geovie
Copy link
Contributor

geovie commented Dec 5, 2018

Hi @ELundby45,
Have you installed the matching Windows 10 SDK (at least build 10.0.17134.0)? If yes, which version of the SDK are you using?
Which version of Visual Studio 2017 are you using?

Maybe including rpc.h (#include <rpc.h>) in napi_winrt.h could solve the problem...

@ELundby45
Copy link
Author

@geovie I have installed the SDKs and it is trying to use 10.0.17763.0 (according to node-gyp configure --verbose)

Visual Studio 2017 v15.9.3

Including rpc.h did remove some of the errors, but still getting quite a few. Do you mind sharing which Visual Studio version and SDK version have worked for you? I can try downgrading.

error_log.log

@geovie
Copy link
Contributor

geovie commented Dec 5, 2018

Looks like the API changed between 10.0.17134.0 and 10.0.17763.0 (it uses now winrt::guid instead of GUID/UUID ). For now it should work if you downgrade to SDK 10.0.17134.0, I will update the code later this week

@ELundby45
Copy link
Author

Got it working. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants