Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report theme formatting oddities and ui inconsistencies here #44

Open
27 tasks
RedFantom opened this issue Aug 19, 2018 · 13 comments
Open
27 tasks

Report theme formatting oddities and ui inconsistencies here #44

RedFantom opened this issue Aug 19, 2018 · 13 comments

Comments

@RedFantom
Copy link
Member

RedFantom commented Aug 19, 2018

None of the themes provided in this repository are perfect. In fact, most contain some small visual errors, that may only become apparent in specific use-cases. If you spot any, please post a screenshot of the afflicted UI elements here, along with a short description of what you think is off. If you provide a clear example of what is wrong, I will fix the issue!

TODO List

  • Adapta
    • Spinbox
    • Treeview Arrows
  • Aquativo
    • Missing: Entry and related images for Spinbox and Combobox
    • Missing: Progressbar
    • Spinbox
    • Entry
    • Combobox
    • OptionMenu graphics glitches
    • Disabled background
    • Notebook non-selected tab glitch
    • Scale: Through when setting sticky
  • Arc
    • Progressbar when setting sticky
  • Equilux
    • Spinbox button arrow button alignment
    • Progressbar when setting sticky
    • Button, Checkbutton, Radiobutton contrasting background
    • Combobox button on the right padding
  • itft1
    • Notebook: Selected tab marking
    • Missing: OptionMenu, Menubutton
  • Yaru
    • Spinbox button glitches
    • Progressbar when setting sticky
    • Combobox: small artifact around the button
@RedFantom RedFantom changed the title Report theme formatting oddities here Report theme formatting oddities and ui inconsistencies here Sep 3, 2018
@kev-a-s
Copy link

kev-a-s commented Jul 25, 2020

image
'Black' theme: Spinbox text not visible unless selected. TSpinbox should have same settings as TCombobox and TEntry. (foreground='black', padding=2)

@Akuli
Copy link
Contributor

Akuli commented Jul 25, 2020

Thanks for reporting this. I have ran across this too but I forgot to report it here.

@rdbende
Copy link
Member

rdbende commented Feb 18, 2021

Adapta:

image
Spinbox is not styled (you commented out the whole spinbox-part, images missing)

image
Notebook client is too contrasty, does not fit the theme (you commented out the Notebook.client-part, image missing)

image
Treview.indicator does not fit the theme (you commented out that part, image missing)

And there are many unnecessary images in the folder.

@rdbende
Copy link
Member

rdbende commented Feb 18, 2021

Aquativo:

image
image
The radio and checkbuttons have a different background color when disabled, which is not good (-disabledbackground is missing from the code):
image

@RedFantom
Copy link
Member Author

Thank you for reporting these! I've put them on the TODO-list.

I remember working on the Adapta theme and noticing that it lacked some images. I must've forgotten to create them 😳 .

@israel-dryer
Copy link

israel-dryer commented Aug 27, 2021

Do you know if the scrollbars on Mac are style-able?? I've not been able to find a way to make a decent dark themed scrollbar on Mac, and it appears this is the case on ttkthemes as well.

image

EDIT ---
hmm... not sure anything can be done about it presently, but let me know. Here's a fascinating paper on the color issues with MacOS and Tkinter for reference. https://www.tcl.tk/community/tcl2019/assets/talk168/Paper.pdf

@rdbende
Copy link
Member

rdbende commented Aug 27, 2021

What Tk version are you using?
Refering to this issue -> ttk::scrollbar Styling there was a problem like this before version 8.6.10.

And I know from here that Tk on macOS uses HIToolbox instead of Cocoa for scrollbars. This may also be the cause of this problem, but I don't really know.

EDIT:
Yeah, the paper you found explains this better than what I found in the meantime.

@israel-dryer
Copy link

Good call. I upgraded via brew and it is now working find.

image
I still find it odd that python.org still ships with and recommends tcl/tk 8.6.8 on Mac, while Mac ships with 8.6.9 natively, and 8.6.11 is available if you upgrade via brew.

Ugh... wondering if dealing with MacOs is worth the trouble... lol

@Akuli
Copy link
Contributor

Akuli commented Oct 3, 2021

'Black' theme: Spinbox text not visible unless selected.

Any update on this? It is still broken after pip install --upgrade ttkthemes

@rdbende
Copy link
Member

rdbende commented Oct 3, 2021

@Akuli PR created

@RedFantom
Copy link
Member Author

@rdbende Thank you, it is merged!

@Arrinao
Copy link

Arrinao commented Oct 19, 2021

https://imgur.com/a/SOfycZL

I'd like to request changing the color of the treeview widget so it's all in dark grey.

@Elvish-Hunter
Copy link

In several themes, when using icons of bigger sizes, Button widgets don't adapt to contain them, so the icon is partially placed outside the widget. Adding or removing a text label to the button doesn't make any difference, and neither does changing the compound value.
See this picture with the Clearlooks theme on Windows 10:
ttk buttons
The issue doesn't happen when styling the button with the Toolbutton style, but this changes its look, so it isn't always the best solution.
The affected themes are blue, clearlooks, elegance, kroc, radiance, ubuntu and smog; all the other themes don't have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants