Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge version of dc.js breaks line charts #29

Open
lfarrell opened this issue Jan 2, 2015 · 2 comments
Open

Edge version of dc.js breaks line charts #29

lfarrell opened this issue Jan 2, 2015 · 2 comments

Comments

@lfarrell
Copy link

lfarrell commented Jan 2, 2015

Line charts no longer appear to work, including your example NASDAQ line charts. They throw the following error: Error: An invalid or illegal string was specified. The issue appears to have been introduced in dc.js 2.0.0-alpha.3, as it works fine with dc.js 2.0.0-alpha.2.

Thanks,

Dean

@lfarrell
Copy link
Author

lfarrell commented Jan 2, 2015

Tom,

The issue appears to be that invalid clip path id's are being generated if you don't specify an id for a chart. For example, #1-clip is being generated for the first clip path if no id is specified. Since an id can't start with a number the selector fails. If I specify an id dc.js takes it and appends "-clip" to it, and everything works fine.

Apparently, dc.js 2.0.0-alpha.2 and lower were taking advantage of a bug when it generated ids, as #1-clip works just fine there. So, I'm not sure if this is a dc.js issue or an angular-dc issue. Hope this helps.

Thanks for all your hard work,

Dean

@TomNeyland
Copy link
Owner

@lfarrell Thanks for the bug report, will try to look into this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants