-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lodash 3.5 #36
Comments
Had to roll back to lodash 2.4.1 to get this working. |
There is a pull request for this error at #34, not merged yet, though. @TomNeyland Were you able to review this request? |
Has this issue been resolved? Receiving the same error with lodash 3.10.1. |
I'm not a huge fan of being cornered into choosing the version of lodash that I use based on a dependency. Thoughts on removing lodash as a dependency of this project? Maybe just implement the parts needed to not force others to have to use the same version of lodash? Any other alternatives I'm not thinking about? |
The lodash incompatibility is resolved by the #34 patch cited above. The other lodash calls in angular-dc are common, stable and appropriate. I suggest that once the patch is merged, the bower lodash dependency be changed from '~2' to '*'. It is highly unlikely that the remaining lodash functions used by angular-dc would change. However, it is advisable to add a comment for contributors listing the allowed lodash functions. |
Getting this error when upgrading to lodash 3.5
dc.errors.InvalidStateException {message: "Mandatory attribute chart.dimension is missing on chart[#dc-chart1]", toString: function}angular.js?body=1:9938 (anonymous function)angular.js?body=1:7284 $getangular.js?body=1:12415 $get.Scope.$digestangular.js?body=1:12661 $get.Scope.$applyangular.js?body=1:8273 doneangular.js?body=1:8478 completeRequestangular.js?body=1:8417 xhr.onreadystatechange
The text was updated successfully, but these errors were encountered: