Problem initializing module with Browserify dependency management

[bencpeters]

When using Browserify to load in angular-dc, I'm getting a "cannot read property 'module' of undefined" error. I'm loading angular-dc as follows:

require('angular-dc');

var app = angular.module('MyApp', ['angularDc']);

The issue is, with Browerify-style imports, we get into this branch of the module logic at the beginning of angular-dc.js:

    } else if (typeof exports === 'object') {
        // Node. Does not work with strict CommonJS, but
        // only CommonJS-like enviroments that support module.exports,
        // like Node.
        module.exports = factory();

This calls the factory function with no arguments, so angular, dc, _, and d3 are all undefined.

It should be fixable by changing to module.exports = factory; (don't call factory, just export the function). Then we could load the module using browserify as follows:

require('angular');

var _ = require('underscore')
  , d3 = require('d3')
  , dc = require('dcjs');

require('angular-dc')(angular, dc, _, d3);

var app = angular.module('MyApp', ['angularDc']);