Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all messages received by client when the server closes the connection and server has sent pings #983

Open
bluelu opened this issue Mar 6, 2020 · 2 comments

Comments

@bluelu
Copy link

bluelu commented Mar 6, 2020

Hi,

Whenever the server sends a ping to the client, the client will not receive all the data which has been queued when the server closes the connection after having flushed all queues.

Please see below for example code.

Thanks

(I had a more inaccurate post here, and I edited so it's more precise now)

@bluelu bluelu closed this as completed Mar 6, 2020
@bluelu
Copy link
Author

bluelu commented Mar 6, 2020

Hi,

I created a sample application to reproduce the error.

The client will be disconnected too early and not received the 1000 messages whenever there I send pings from the server.

https://pastebin.com/sKiu49Gw

Thanks

@bluelu bluelu reopened this Mar 6, 2020
@bluelu bluelu changed the title Not all messages received by client when the server closes the connection Not all messages received by client when the server closes the connection and server has sent pings Mar 9, 2020
@marci4
Copy link
Collaborator

marci4 commented Mar 9, 2020

Hello @bluelu,
thx for reporting this issue!

I created a unit test based on your steps to repeat.
https://gist.github.com/marci4/a4719b223d88a902423c1252aba24ffc

Issue seems to be caused by an abnormal close, but not sure why yet!

Anyone feel free to take a deeper look at this issue!

Best regards,
Marcel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants