Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrong channel_mode during animations #64

Open
readableness opened this issue Apr 16, 2024 · 0 comments
Open

Bug: wrong channel_mode during animations #64

readableness opened this issue Apr 16, 2024 · 0 comments

Comments

@readableness
Copy link

Cycling {strobe -> off -> ramp} doesn't maintain and restore channel_mode (tint mix) during smooth_steps.

Steps to reproduce, for example on a 2-channel light with ramp using default CM_BLEND of both channels and default USE_SMOOTH_STEPS enabled:

  1. Set strobe-mode candle to CM_CH1 only (repeat 3C until set for a single emitter channel)
  2. Enjoy your candle (0C)
  3. Turn off candle (1C). Observe unpleasant activation of second emitter channel during fade animation to off.

Without the additional restoration of ramp's channel_mode during event == EV_tick, the channel_mode can be incorrect during smooth animation to on, jumping to correct at animation end.

Fixed by #63
readableness pushed a commit to readableness/anduril that referenced this issue Apr 20, 2024
Bugfix: keep channel_mode during smooth_steps from strobe to off,
603b7be 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Jul 16, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
6e23370 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
a897d29 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
e771e24 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
d54e148 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
41b92c4 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
d052ab1 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
fa3aa75 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
965c206 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
a6f3d91 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
82e1d60 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
24e1ea6 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 14, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
b647e2a 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Isilmerie pushed a commit to Isilmerie/anduril that referenced this issue Oct 16, 2024
@Isilmerie
Bugfix: keep channel_mode during smooth_steps from strobe to off,
57325cf 
        restore ramp channel_mode before on.

Fixes ToyKeeper#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@readableness