Bug: Can't access strobe mode on dual-channel Emisar D4V2 #94
Comments
fwiffo
changed the title
fwiffo
added a commit
to fwiffo/anduril
that referenced
this issue
Sep 1, 2024
The fix for ToyKeeper#85 moved the strobe mode event in off-mode.c inside an ifdef USE_SIMPLE_UI block where they did not belong. Moving them below that block fixes ToyKeeper#94.
|
OK, I was wrong, it is that commit causing the problem. I've got a fix and will send a pull request. |
fwiffo
added a commit
to fwiffo/anduril
that referenced
this issue
Sep 1, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
|
I can confirm this bug, when I tried to compile PL47G2 without simple UI. |
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 16, 2024
Looks like this inadvertantly got placed inside an #ifdef USE_SIMPLE_UI block when fixing ToyKeeper#85. Moving it below that block fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With a build from head, I'm not able access strobe mode with 3H from off. I verified that I'm not in Simple mode, and to be doubly sure, I built and flashed a version with Simple UI totally disabled. I verified that the appropriate #defines are enabled to include all the strobe mode stuff.
I don't know if this is a model-specific issue, or something specific to dual channel lights, or if it's a problem generally.
As far as I can tell, commit 4f7f90d (the fix for #85) is not the cause, but I could be mistaken.
The text was updated successfully, but these errors were encountered: