Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Jump-start flashes channels that should remain off on dual-channel lights under some circumstances (example fix attached) #96

Open
fwiffo opened this issue Aug 26, 2024 · 0 comments

Comments

@fwiffo
Copy link

fwiffo commented Aug 26, 2024

If you're in tint-autoramp mode and enter moonlight mode, both channels will flash briefly due to jump-starting. This is because jump-starting is implemented assuming a single-channel configuration. The PWM value may be zero for some channels at floor level, but not at the jump-start level.

The fix is to handle jump-starting within the multi-channel logic by computing any blending based on the "real" level and then jump-starting only those channels that have resulting non-zero PWM values. I've implemented a prototype fix for the 2-channel Emisar (model 0135), which is the only light I have to test on. I can create a more complete implementation if there is interest: fwiffo@c3d9321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant