-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar should roll away on selection #145
Comments
You should probably use a menu for cases where you want the box to close when an item is selected. With the most recent changes you can use multiple sidebars and menus, so you can style a menu like a sidebar and achieve that behaviour. Menu and sidebar are a bit awkward names, it is better to think of them as a container that closes when a mouse is clicked anywhere (menu) and a container that is closed when a mouse is clicked anywhere but the container or other containers of the same type (sidebar.) Perhaps we should come up with better names, any suggestions? |
Will need to support scrolling/swiping on these menu/sidebar hybrids as well. Will need to think about this design. |
Sorry about the multiple pushes, I made a mess while rebasing :) Bram:
I agree with the general principle; still, sidebars scroll and menus don't, so in general they are what people want. |
Pull request is #280 |
Auto-close the sidebar on click (#145).
An implementation of this has been merged a while back. |
After you select where you want to go the sidebar should become inactive.
The text was updated successfully, but these errors were encountered: