Skip to content

Latest commit

 

History

History
16 lines (15 loc) · 757 Bytes

code_review_guideline.md

File metadata and controls

16 lines (15 loc) · 757 Bytes

Code Review Guideline

  • Branch name as SPRINT/ISSUE_KEY/feature_name
  • Commit message as ISSUE_KEY | Change summary in imperative mood
  • Using dev_process branches for large features
  • Max line length as 120
  • Declaring return type for methods
  • Pushing comment outed code to repository if only it has TODO or explanation
  • Creating JIRA tasks if TODOs are not solved any time soon
  • Creating stash task for the comment which requires code change
  • Pushing code with unit test
  • At least 4 approve from related domain (checkout-browser) for opened pr
  • Code style which follows team conventions
  • Comment or documentation for complicated logic
  • Developer test before opening pr
  • UI tests (in progress)