Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify template code for quick install trow.yaml is needed #248

Open
amouat opened this issue Apr 21, 2021 · 2 comments
Open

Verify template code for quick install trow.yaml is needed #248

amouat opened this issue Apr 21, 2021 · 2 comments

Comments

@amouat
Copy link
Contributor

amouat commented Apr 21, 2021

Currently the YAML file for the quick install templates out the namespace with {{namespace}}. Before applying the YAML, the template is replaced using a simple sed call. This is fine, but a bit complicated - it means end users can't simply apply the YAML.

It's not clear from a casual glance why we can't just do kubectl apply -n NAMESPACE instead of the templating. Possibly this will break something. We should verify this and update the code to the simpler version possible. This will need to be tested on different platforms.

@journeytosilius
Copy link

journeytosilius commented Apr 27, 2021

a solution might be to write a simple k8s operator instead of using bash scripts. Thank you for this, since I have been using it with success for some month now. The reason for the automatic deployment is that without it, you can't really add trow to a full automated cluster deployment with ansible, or at least it would be more difficult than expected

@amouat
Copy link
Contributor Author

amouat commented Apr 27, 2021

Thanks! Would you mind sending me an e-mail? I'm curious about your use-case! [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants