🐛 Fixed repeating text in plaintext version of emails #17162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes https://github.com/TryGhost/Team/issues/3541 The email preheader, which is only present in the html version of an email, is also included in the plaintext version of all emails. This results in all text being duplicated twice in plaintext emails.
SimonBackx
force-pushed
the
fix-preheader-in-plaintexct
branch
from
ce84f6c
to
516f688
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #17162 +/- ##
==========================================
+ Coverage 71.62% 71.69% +0.06%
==========================================
Files 1833 1833
Lines 116265 116267 +2
Branches 17255 17277 +22
==========================================
+ Hits 83270 83352 +82
+ Misses 31874 31788 -86
- Partials 1121 1127 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/TryGhost/Team/issues/3541
The email preheader, which is only present in the html version of an email, is also included in the plaintext version of all emails. This results in all text being duplicated twice in plaintext emails.