From d2a249706ea85cbe49182877554fcadb804bbbe7 Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Mon, 11 Sep 2023 16:54:27 +0300
Subject: [PATCH 1/6] add a check for new required default parameter for a
 request on an existing path

---
 BREAKING-CHANGES-EXAMPLES.md                  |  1 +
 ...-new-request-non-path-default-parameter.go | 44 +++++++++++
 ...request-non-path-default-parameter_test.go | 61 ++++++++++++++++
 checker/localizations/localizations.go        |  6 +-
 checker/localizations_src/en/messages.yaml    |  2 +
 checker/localizations_src/ru/messages.yaml    |  2 +
 .../required-request-params.yaml              | 73 +++++++++++++++++++
 7 files changed, 188 insertions(+), 1 deletion(-)
 create mode 100644 checker/check-new-request-non-path-default-parameter.go
 create mode 100644 checker/check-new-request-non-path-default-parameter_test.go
 create mode 100644 data/request_params/required-request-params.yaml

diff --git a/BREAKING-CHANGES-EXAMPLES.md b/BREAKING-CHANGES-EXAMPLES.md
index 7aff36e5..fbe9f0c0 100644
--- a/BREAKING-CHANGES-EXAMPLES.md
+++ b/BREAKING-CHANGES-EXAMPLES.md
@@ -57,6 +57,7 @@ These examples are automatically generated from unit tests.
 [modifying a pattern in a schema is breaking](checker/checker_breaking_test.go?plain=1#L491)  
 [modifying a pattern in request parameter is breaking](checker/checker_breaking_test.go?plain=1#L507)  
 [modifying the default value of an optional request parameter is breaking](checker/checker_breaking_test.go?plain=1#L537)  
+[new header, query and cookie required request default param is breaking](checker/check-new-request-non-path-default-parameter_test.go?plain=1#L11)  
 [new required header param is breaking](checker/checker_breaking_test.go?plain=1#L171)  
 [new required path param is breaking](checker/checker_breaking_test.go?plain=1#L155)  
 [new required property in request header is breaking](checker/checker_breaking_property_test.go?plain=1#L17)  
diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
new file mode 100644
index 00000000..4ca76c6f
--- /dev/null
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -0,0 +1,44 @@
+package checker
+
+import (
+	"fmt"
+	"github.com/tufin/oasdiff/diff"
+)
+
+func NewNonPathRequestDefaultParameterCheck(diffReport *diff.Diff, _ *diff.OperationsSourcesMap, config Config) Changes {
+	result := make(Changes, 0)
+	if diffReport.PathsDiff == nil || len(diffReport.PathsDiff.Modified) == 0 {
+		return result
+	}
+	for path, pathItem := range diffReport.PathsDiff.Modified {
+		if pathItem.ParametersDiff == nil {
+			continue
+		}
+		for paramLoc, paramNameList := range pathItem.ParametersDiff.Added {
+			if paramLoc == "path" {
+				continue
+			}
+			for _, n := range paramNameList {
+				fmt.Print(n)
+			}
+			for _, param := range pathItem.Revision.Parameters {
+				if !paramNameList.Contains(param.Value.Name) {
+					continue
+				}
+				id := "new-required-request-default-parameter-to-existing-path"
+				level := ERR
+				if !param.Value.Required {
+					id = "new-optional-request-default-parameter-to-existing-path"
+					level = INFO
+				}
+				result = append(result, ApiChange{
+					Id:    id,
+					Level: level,
+					Text:  config.Localize(id, ColorizedValue(paramLoc), ColorizedValue(param.Value.Name)),
+					Path:  path,
+				})
+			}
+		}
+	}
+	return result
+}
diff --git a/checker/check-new-request-non-path-default-parameter_test.go b/checker/check-new-request-non-path-default-parameter_test.go
new file mode 100644
index 00000000..19c99681
--- /dev/null
+++ b/checker/check-new-request-non-path-default-parameter_test.go
@@ -0,0 +1,61 @@
+package checker_test
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"github.com/tufin/oasdiff/checker"
+	"github.com/tufin/oasdiff/diff"
+)
+
+// BC: new header, query and cookie required request default param is breaking
+func TestNewRequestNonPathParameter_DetectsNewRequiredPathsAndNewOperations(t *testing.T) {
+	s1, err := open("../data/request_params/base.yaml")
+	require.NoError(t, err)
+
+	s2, err := open("../data/request_params/required-request-params.yaml")
+	require.NoError(t, err)
+
+	d, osm, err := diff.GetWithOperationsSourcesMap(&diff.Config{}, s1, s2)
+	require.NoError(t, err)
+
+	errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.NewNonPathRequestDefaultParameterCheck), d, osm, checker.INFO)
+	require.NotEmpty(t, errs)
+	require.Len(t, errs, 5)
+
+	require.IsType(t, checker.ApiChange{}, errs[0])
+	e0 := errs[0].(checker.ApiChange)
+	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e0.Id)
+	require.Equal(t, "/api/test1", e0.Path)
+	require.Equal(t, checker.ERR, e0.Level)
+	require.Contains(t, e0.Text, "version")
+
+	require.IsType(t, checker.ApiChange{}, errs[1])
+	e1 := errs[1].(checker.ApiChange)
+	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e1.Id)
+	require.Equal(t, "/api/test2", e1.Path)
+	require.Equal(t, checker.ERR, e1.Level)
+	require.Contains(t, e1.Text, "id")
+
+	require.IsType(t, checker.ApiChange{}, errs[2])
+	e2 := errs[2].(checker.ApiChange)
+	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e2.Id)
+	require.Equal(t, "/api/test3", e2.Path)
+	require.Equal(t, checker.ERR, e2.Level)
+	require.Contains(t, e2.Text, "If-None-Match")
+
+	require.IsType(t, checker.ApiChange{}, errs[3])
+	e3 := errs[3].(checker.ApiChange)
+	require.Equal(t, "new-optional-request-default-parameter-to-existing-path", e3.Id)
+	require.Equal(t, "/api/test1", e3.Path)
+	require.Equal(t, checker.INFO, e3.Level)
+	require.Contains(t, e3.Text, "optionalQueryParam")
+
+	require.IsType(t, checker.ApiChange{}, errs[4])
+	e4 := errs[4].(checker.ApiChange)
+	require.Equal(t, "new-optional-request-default-parameter-to-existing-path", e4.Id)
+	require.Equal(t, "/api/test2", e4.Path)
+	require.Equal(t, checker.INFO, e4.Level)
+	require.Contains(t, e4.Text, "optionalHeaderParam")
+
+}
diff --git a/checker/localizations/localizations.go b/checker/localizations/localizations.go
index d9c16b87..9d00fd47 100644
--- a/checker/localizations/localizations.go
+++ b/checker/localizations/localizations.go
@@ -1,6 +1,6 @@
 // Code generated by go-localize; DO NOT EDIT.
 // This file was generated by robots at
-// 2023-08-04 10:55:40.9774 +0100 IST m=+0.005745834
+// 2023-09-11 16:39:50.19002 +0300 IDT m=+0.007249459
 
 package localizations
 
@@ -46,9 +46,11 @@ var localizations = map[string]string{
 	"en.messages.endpoint-deprecated":                                      "endpoint deprecated",
 	"en.messages.endpoint-reactivated":                                     "endpoint reactivated",
 	"en.messages.in":                                                       "in",
+	"en.messages.new-optional-request-default-parameter-to-existing-path":  "added the new optional %s request parameter %s to all path's operations",
 	"en.messages.new-optional-request-parameter":                           "added the new optional %s request parameter %s",
 	"en.messages.new-optional-request-property":                            "added the new optional request property %s",
 	"en.messages.new-request-path-parameter":                               "added the new path request parameter %s",
+	"en.messages.new-required-request-default-parameter-to-existing-path":  "added the new required %s request parameter %s to all path's operations",
 	"en.messages.new-required-request-header-property":                     "added the new required %s request header's property %s",
 	"en.messages.new-required-request-parameter":                           "added the new required %s request parameter %s",
 	"en.messages.new-required-request-property":                            "added the new required request property %s",
@@ -310,9 +312,11 @@ var localizations = map[string]string{
 	"ru.messages.api-tag-removed":                                          "Тег API %s удален",
 	"ru.messages.at":                                                       "в",
 	"ru.messages.in":                                                       "в",
+	"ru.messages.new-optional-request-default-parameter-to-existing-path":  "добавлен новый необязательный %s параметр запроса %s ко всем операциям пути",
 	"ru.messages.new-optional-request-parameter":                           "добавлен новый необязательный %s параметр зароса %s",
 	"ru.messages.new-optional-request-property":                            "добавлено новое необязательное поле запроса %s",
 	"ru.messages.new-request-path-parameter":                               "добален новый path параметр запроса %s",
+	"ru.messages.new-required-request-default-parameter-to-existing-path":  "добавлен новый обязательный %s параметр запроса %s для всех операций пути",
 	"ru.messages.new-required-request-header-property":                     "в заголовке запроса %s добавлено новое обязательное поле %s",
 	"ru.messages.new-required-request-parameter":                           "добавлен новый обязательный %s параметр зароса %s",
 	"ru.messages.new-required-request-property":                            "добавлено новое обязательное поле запроса %s",
diff --git a/checker/localizations_src/en/messages.yaml b/checker/localizations_src/en/messages.yaml
index d214b45f..39440083 100644
--- a/checker/localizations_src/en/messages.yaml
+++ b/checker/localizations_src/en/messages.yaml
@@ -262,3 +262,5 @@ request-optional-property-became-not-write-only: the request optional property %
 request-optional-property-became-not-read-only: the request optional property %s became not read-only
 request-required-property-became-write-only: the request required property %s became write-only
 request-required-property-became-not-write-only: the request required property %s became not write-only
+new-required-request-default-parameter-to-existing-path: added the new required %s request parameter %s to all path's operations
+new-optional-request-default-parameter-to-existing-path: added the new optional %s request parameter %s to all path's operations
diff --git a/checker/localizations_src/ru/messages.yaml b/checker/localizations_src/ru/messages.yaml
index bb2cf59f..ca8edb41 100644
--- a/checker/localizations_src/ru/messages.yaml
+++ b/checker/localizations_src/ru/messages.yaml
@@ -262,3 +262,5 @@ request-optional-property-became-not-write-only: необязательное п
 request-optional-property-became-not-read-only: необязательное поле запроса %s перестало быть только для чтения
 request-required-property-became-write-only: обязательное поле запроса %s стало только для записи
 request-required-property-became-not-write-only: обязательное поле запроса %s перестало быть только для записи
+new-required-request-default-parameter-to-existing-path: добавлен новый обязательный %s параметр запроса %s для всех операций пути
+new-optional-request-default-parameter-to-existing-path: добавлен новый необязательный %s параметр запроса %s ко всем операциям пути
diff --git a/data/request_params/required-request-params.yaml b/data/request_params/required-request-params.yaml
new file mode 100644
index 00000000..c19716f6
--- /dev/null
+++ b/data/request_params/required-request-params.yaml
@@ -0,0 +1,73 @@
+info:
+  title: Tufin
+  version: 1.0.0
+openapi: 3.0.3
+paths:
+  /api/test1:
+    parameters:
+      - in: query
+        name: version
+        required: true
+        schema:
+          type: string
+      - in: query
+        name: optionalQueryParam
+        required: false
+        schema:
+          type: string
+    get:
+      operationId: getTest
+      parameters:
+        - in: header
+          name: X-NewRequestHeaderParam
+          required: false
+          schema:
+            type: string
+      responses:
+        200:
+          description: OK
+    post:
+      responses:
+        201:
+          description: OK
+
+  /api/test2:
+    parameters:
+      - in: query
+        name: id
+        required: true
+        schema:
+          type: string
+      - in: header
+        name: optionalHeaderParam
+        required: false
+        schema:
+          type: string
+    get:
+      operationId: getTest
+      parameters:
+        - in: query
+          name: newQueryParam
+          required: false
+          schema:
+            type: string
+      responses:
+        200:
+          description: OK
+
+  /api/test3:
+    parameters:
+      - in: header
+        name: If-None-Match
+        required: true
+    get:
+      operationId: getTest
+      parameters:
+        - in: cookie
+          name: csrf-token
+          required: false
+          schema:
+            type: string
+      responses:
+        200:
+          description: OK

From e3b94fcb8f4b9a163072fd49dcc0262c2956e3ec Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Mon, 11 Sep 2023 16:55:50 +0300
Subject: [PATCH 2/6] remove unnecessary printing loop

---
 checker/check-new-request-non-path-default-parameter.go | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
index 4ca76c6f..83aab40d 100644
--- a/checker/check-new-request-non-path-default-parameter.go
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -1,7 +1,6 @@
 package checker
 
 import (
-	"fmt"
 	"github.com/tufin/oasdiff/diff"
 )
 
@@ -18,9 +17,6 @@ func NewNonPathRequestDefaultParameterCheck(diffReport *diff.Diff, _ *diff.Opera
 			if paramLoc == "path" {
 				continue
 			}
-			for _, n := range paramNameList {
-				fmt.Print(n)
-			}
 			for _, param := range pathItem.Revision.Parameters {
 				if !paramNameList.Contains(param.Value.Name) {
 					continue

From 2cba69504cb9543186f6522d890dc33ca252eb68 Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Mon, 11 Sep 2023 22:46:41 +0300
Subject: [PATCH 3/6] rename NewNonPathRequestDefaultParameterCheck to
 NewRequestNonPathDefaultParameterCheck. add
 NewRequestNonPathDefaultParameterCheck to defaultChecks

---
 checker/check-new-request-non-path-default-parameter.go      | 2 +-
 checker/check-new-request-non-path-default-parameter_test.go | 2 +-
 checker/default_checks.go                                    | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
index 83aab40d..0c8c3e11 100644
--- a/checker/check-new-request-non-path-default-parameter.go
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -4,7 +4,7 @@ import (
 	"github.com/tufin/oasdiff/diff"
 )
 
-func NewNonPathRequestDefaultParameterCheck(diffReport *diff.Diff, _ *diff.OperationsSourcesMap, config Config) Changes {
+func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, _ *diff.OperationsSourcesMap, config Config) Changes {
 	result := make(Changes, 0)
 	if diffReport.PathsDiff == nil || len(diffReport.PathsDiff.Modified) == 0 {
 		return result
diff --git a/checker/check-new-request-non-path-default-parameter_test.go b/checker/check-new-request-non-path-default-parameter_test.go
index 19c99681..8dcf6788 100644
--- a/checker/check-new-request-non-path-default-parameter_test.go
+++ b/checker/check-new-request-non-path-default-parameter_test.go
@@ -19,7 +19,7 @@ func TestNewRequestNonPathParameter_DetectsNewRequiredPathsAndNewOperations(t *t
 	d, osm, err := diff.GetWithOperationsSourcesMap(&diff.Config{}, s1, s2)
 	require.NoError(t, err)
 
-	errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.NewNonPathRequestDefaultParameterCheck), d, osm, checker.INFO)
+	errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.NewRequestNonPathDefaultParameterCheck), d, osm, checker.INFO)
 	require.NotEmpty(t, errs)
 	require.Len(t, errs, 5)
 
diff --git a/checker/default_checks.go b/checker/default_checks.go
index cd360923..3fb0a2c3 100644
--- a/checker/default_checks.go
+++ b/checker/default_checks.go
@@ -67,6 +67,7 @@ func defaultChecks() []BackwardCompatibilityCheck {
 		APISecurityUpdatedCheck,
 		APISunsetChangedCheck,
 		AddedRequiredRequestBodyCheck,
+		NewRequestNonPathDefaultParameterCheck,
 		NewRequestNonPathParameterCheck,
 		NewRequestPathParameterCheck,
 		NewRequiredRequestHeaderPropertyCheck,

From 6b311d7529c84502e20c6fb53521473805d1a2db Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Thu, 14 Sep 2023 17:22:48 +0300
Subject: [PATCH 4/6] add Revision nil check

---
 checker/check-new-request-non-path-default-parameter.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
index 0c8c3e11..9b429601 100644
--- a/checker/check-new-request-non-path-default-parameter.go
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -10,7 +10,7 @@ func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, _ *diff.Opera
 		return result
 	}
 	for path, pathItem := range diffReport.PathsDiff.Modified {
-		if pathItem.ParametersDiff == nil {
+		if pathItem.ParametersDiff == nil || pathItem.Revision == nil {
 			continue
 		}
 		for paramLoc, paramNameList := range pathItem.ParametersDiff.Added {

From 4571825e7a1fd29faf4d923827538a2df5c9a5b8 Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Thu, 14 Sep 2023 19:07:24 +0300
Subject: [PATCH 5/6] add a check for empty path operations

---
 checker/check-new-request-non-path-default-parameter.go | 2 +-
 data/request_params/base.yaml                           | 9 +++++++++
 data/request_params/required-request-params.yaml        | 8 ++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
index 9b429601..819f789c 100644
--- a/checker/check-new-request-non-path-default-parameter.go
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -10,7 +10,7 @@ func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, _ *diff.Opera
 		return result
 	}
 	for path, pathItem := range diffReport.PathsDiff.Modified {
-		if pathItem.ParametersDiff == nil || pathItem.Revision == nil {
+		if pathItem.ParametersDiff == nil || pathItem.Revision == nil || len(pathItem.Revision.Operations()) == 0 {
 			continue
 		}
 		for paramLoc, paramNameList := range pathItem.ParametersDiff.Added {
diff --git a/data/request_params/base.yaml b/data/request_params/base.yaml
index 09cc74e6..1ae909f4 100644
--- a/data/request_params/base.yaml
+++ b/data/request_params/base.yaml
@@ -27,3 +27,12 @@ paths:
       responses:
         200:
           description: OK
+
+  /api/test4:
+    parameters:
+      - in: query
+        name: emptyPath
+        required: false
+        schema:
+          type: string
+
diff --git a/data/request_params/required-request-params.yaml b/data/request_params/required-request-params.yaml
index c19716f6..1439c12e 100644
--- a/data/request_params/required-request-params.yaml
+++ b/data/request_params/required-request-params.yaml
@@ -71,3 +71,11 @@ paths:
       responses:
         200:
           description: OK
+
+  /api/test4:
+    parameters:
+      - in: query
+        name: emptyPath2
+        required: true
+        schema:
+          type: string

From 949bb2e75f120c7cd849456aa099704412361041 Mon Sep 17 00:00:00 2001
From: Jonathan Rosenberg
 <96974219+Jonathan-Rosenberg@users.noreply.github.com>
Date: Thu, 14 Sep 2023 19:07:24 +0300
Subject: [PATCH 6/6] report BC error per endpoint

---
 ...-new-request-non-path-default-parameter.go |  31 +++--
 ...request-non-path-default-parameter_test.go | 128 +++++++++++++-----
 data/request_params/base.yaml                 |   9 ++
 .../required-request-params.yaml              |   8 ++
 4 files changed, 129 insertions(+), 47 deletions(-)

diff --git a/checker/check-new-request-non-path-default-parameter.go b/checker/check-new-request-non-path-default-parameter.go
index 9b429601..9f4fa704 100644
--- a/checker/check-new-request-non-path-default-parameter.go
+++ b/checker/check-new-request-non-path-default-parameter.go
@@ -4,7 +4,7 @@ import (
 	"github.com/tufin/oasdiff/diff"
 )
 
-func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, _ *diff.OperationsSourcesMap, config Config) Changes {
+func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, operationsSources *diff.OperationsSourcesMap, config Config) Changes {
 	result := make(Changes, 0)
 	if diffReport.PathsDiff == nil || len(diffReport.PathsDiff.Modified) == 0 {
 		return result
@@ -13,26 +13,35 @@ func NewRequestNonPathDefaultParameterCheck(diffReport *diff.Diff, _ *diff.Opera
 		if pathItem.ParametersDiff == nil || pathItem.Revision == nil {
 			continue
 		}
-		for paramLoc, paramNameList := range pathItem.ParametersDiff.Added {
+
+		for paramLoc := range pathItem.ParametersDiff.Added {
 			if paramLoc == "path" {
 				continue
 			}
+
 			for _, param := range pathItem.Revision.Parameters {
-				if !paramNameList.Contains(param.Value.Name) {
-					continue
-				}
+
 				id := "new-required-request-default-parameter-to-existing-path"
 				level := ERR
 				if !param.Value.Required {
 					id = "new-optional-request-default-parameter-to-existing-path"
 					level = INFO
 				}
-				result = append(result, ApiChange{
-					Id:    id,
-					Level: level,
-					Text:  config.Localize(id, ColorizedValue(paramLoc), ColorizedValue(param.Value.Name)),
-					Path:  path,
-				})
+
+				for operation, operationItem := range pathItem.Revision.Operations() {
+
+					// TODO: if base operation had this param individually (not through the path) - continue
+
+					result = append(result, ApiChange{
+						Id:          id,
+						Level:       level,
+						Text:        config.Localize(id, ColorizedValue(paramLoc), ColorizedValue(param.Value.Name)),
+						Operation:   operation,
+						OperationId: operationItem.OperationID,
+						Path:        path,
+						Source:      (*operationsSources)[operationItem],
+					})
+				}
 			}
 		}
 	}
diff --git a/checker/check-new-request-non-path-default-parameter_test.go b/checker/check-new-request-non-path-default-parameter_test.go
index 8dcf6788..b1f71088 100644
--- a/checker/check-new-request-non-path-default-parameter_test.go
+++ b/checker/check-new-request-non-path-default-parameter_test.go
@@ -21,41 +21,97 @@ func TestNewRequestNonPathParameter_DetectsNewRequiredPathsAndNewOperations(t *t
 
 	errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.NewRequestNonPathDefaultParameterCheck), d, osm, checker.INFO)
 	require.NotEmpty(t, errs)
-	require.Len(t, errs, 5)
-
-	require.IsType(t, checker.ApiChange{}, errs[0])
-	e0 := errs[0].(checker.ApiChange)
-	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e0.Id)
-	require.Equal(t, "/api/test1", e0.Path)
-	require.Equal(t, checker.ERR, e0.Level)
-	require.Contains(t, e0.Text, "version")
-
-	require.IsType(t, checker.ApiChange{}, errs[1])
-	e1 := errs[1].(checker.ApiChange)
-	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e1.Id)
-	require.Equal(t, "/api/test2", e1.Path)
-	require.Equal(t, checker.ERR, e1.Level)
-	require.Contains(t, e1.Text, "id")
-
-	require.IsType(t, checker.ApiChange{}, errs[2])
-	e2 := errs[2].(checker.ApiChange)
-	require.Equal(t, "new-required-request-default-parameter-to-existing-path", e2.Id)
-	require.Equal(t, "/api/test3", e2.Path)
-	require.Equal(t, checker.ERR, e2.Level)
-	require.Contains(t, e2.Text, "If-None-Match")
-
-	require.IsType(t, checker.ApiChange{}, errs[3])
-	e3 := errs[3].(checker.ApiChange)
-	require.Equal(t, "new-optional-request-default-parameter-to-existing-path", e3.Id)
-	require.Equal(t, "/api/test1", e3.Path)
-	require.Equal(t, checker.INFO, e3.Level)
-	require.Contains(t, e3.Text, "optionalQueryParam")
-
-	require.IsType(t, checker.ApiChange{}, errs[4])
-	e4 := errs[4].(checker.ApiChange)
-	require.Equal(t, "new-optional-request-default-parameter-to-existing-path", e4.Id)
-	require.Equal(t, "/api/test2", e4.Path)
-	require.Equal(t, checker.INFO, e4.Level)
-	require.Contains(t, e4.Text, "optionalHeaderParam")
+	require.Len(t, errs, 9)
 
+	require.ElementsMatch(t, []checker.ApiChange{
+		{
+			Id:          "new-required-request-default-parameter-to-existing-path",
+			Text:        "added the new required 'query' request parameter 'version' to all path's operations",
+			Comment:     "",
+			Level:       3,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test1",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-required-request-default-parameter-to-existing-path",
+			Text:        "added the new required 'query' request parameter 'version' to all path's operations",
+			Comment:     "",
+			Level:       3,
+			Operation:   "POST",
+			OperationId: "",
+			Path:        "/api/test1",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-required-request-default-parameter-to-existing-path",
+			Text:        "added the new required 'header' request parameter 'id' to all path's operations",
+			Comment:     "",
+			Level:       3,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test2",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-required-request-default-parameter-to-existing-path",
+			Text:        "added the new required 'query' request parameter 'id' to all path's operations",
+			Comment:     "",
+			Level:       3,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test2",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-required-request-default-parameter-to-existing-path",
+			Text:        "added the new required 'header' request parameter 'If-None-Match' to all path's operations",
+			Comment:     "",
+			Level:       3,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test3",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-optional-request-default-parameter-to-existing-path",
+			Text:        "added the new optional 'query' request parameter 'optionalQueryParam' to all path's operations",
+			Comment:     "",
+			Level:       1,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test1",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-optional-request-default-parameter-to-existing-path",
+			Text:        "added the new optional 'query' request parameter 'optionalQueryParam' to all path's operations",
+			Comment:     "",
+			Level:       1,
+			Operation:   "POST",
+			OperationId: "",
+			Path:        "/api/test1",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-optional-request-default-parameter-to-existing-path",
+			Text:        "added the new optional 'header' request parameter 'optionalHeaderParam' to all path's operations",
+			Comment:     "",
+			Level:       1,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test2",
+			Source:      "../data/request_params/required-request-params.yaml",
+		},
+		{
+			Id:          "new-optional-request-default-parameter-to-existing-path",
+			Text:        "added the new optional 'query' request parameter 'optionalHeaderParam' to all path's operations",
+			Comment:     "",
+			Level:       1,
+			Operation:   "GET",
+			OperationId: "getTest",
+			Path:        "/api/test2",
+			Source:      "../data/request_params/required-request-params.yaml",
+		}}, errs)
 }
diff --git a/data/request_params/base.yaml b/data/request_params/base.yaml
index 09cc74e6..1ae909f4 100644
--- a/data/request_params/base.yaml
+++ b/data/request_params/base.yaml
@@ -27,3 +27,12 @@ paths:
       responses:
         200:
           description: OK
+
+  /api/test4:
+    parameters:
+      - in: query
+        name: emptyPath
+        required: false
+        schema:
+          type: string
+
diff --git a/data/request_params/required-request-params.yaml b/data/request_params/required-request-params.yaml
index c19716f6..1439c12e 100644
--- a/data/request_params/required-request-params.yaml
+++ b/data/request_params/required-request-params.yaml
@@ -71,3 +71,11 @@ paths:
       responses:
         200:
           description: OK
+
+  /api/test4:
+    parameters:
+      - in: query
+        name: emptyPath2
+        required: true
+        schema:
+          type: string