Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional incompatibility mods #11

Open
KITE2459 opened this issue Aug 25, 2024 · 9 comments
Open

Additional incompatibility mods #11

KITE2459 opened this issue Aug 25, 2024 · 9 comments

Comments

@KITE2459
Copy link

the mod loader used is fabric

[ScalableLux]
https://modrinth.com/mod/scalablelux
it doesn't work because it's a starlight fork of island that made c2me.
it says incompatibility from the server boot.

[no-portals]
https://modrinth.com/mod/no-portals

[servercore]
https://modrinth.com/mod/servercore

these mods are not on the incompatible list

thanks for developing another optimization mod

@R00tB33rMan
Copy link

the mod loader used is fabric

[ScalableLux] https://modrinth.com/mod/scalablelux it doesn't work because it's a starlight fork of island that made c2me. it says incompatibility from the server boot.

[no-portals] https://modrinth.com/mod/no-portals

[servercore] https://modrinth.com/mod/servercore

these mods are not on the incompatible list

thanks for developing another optimization mod

I cannot speak for No-Portals & ServerCore, as they appear to provide various changes that are unrelated to Moonrise; however, ScalableLux probably will never be compatible, as Moonrise contains Starlight's patches, which effectively makes using ScalableLux pointless if you're planning on using Moonrise on your server.

@sternschnaube
Copy link

Any plans to make the Starlight patches optional via config to support ScalableLux @R00tB33rMan?
Since it has further optimisations.

@kennytv
Copy link

kennytv commented Aug 26, 2024

ScalableLux is just an outdated version of Starlight besides their one extra patch, and generally speaking lighting chunks isn't a bottleneck or something that would need that kind of parallelization

@ImYosu
Copy link

ImYosu commented Aug 31, 2024

Apparently servercore is compatible with moonrise, since 4 days ago in neo and fabric.
(https://github.com/user-attachments/assets/1b205d0a-99c3-4c51-a0c1-111adf9e7777)

@coco875
Copy link

coco875 commented Sep 4, 2024

Chunky don't generate chunk and chunk-pregenerator crash when running a benchmark or any task

@coco875
Copy link

coco875 commented Sep 4, 2024

forgematica (neoforge port of litematica) also crash like litematica on fabric

@coco875
Copy link

coco875 commented Sep 4, 2024

with connector, debugify (with some tweak), vmp crash like on fabric

@derjungeinhd
Copy link

Open Parties and Claims by Xaero and Vanish by DrexHD also seem to crash the server on fabric and it seems there are some Mixin Shenanegans with ModernFix going on

@tajemniktv
Copy link

tajemniktv commented Sep 16, 2024

LOG on mclogs
edit: fun fact, my prism borked uploading to mclogs so no logs for now, apologies

most likely this mixin:

mixin.random.world (true) - Replaces all references of Random in World with my implementation

edit2: actually, there are even more incompats with potatooptimzie

org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_259::redirectListPair1 with priority 1000 cannot inject into net/minecraft/class_259::method_1082(Lnet/minecraft/class_265;Lnet/minecraft/class_265;Lnet/minecraft/class_247;)Lnet/minecraft/class_265; merged by ca.spottedleaf.moonrise.mixin.collisions.ShapesMixin with priority 1000 [INJECT_PREPARE Applicator Phase -> potatoptimize.mixins.json:logic.shape.VoxelShapesMixin from mod potatoptimize -> Prepare Injections -> redirect$kdc000$potatoptimize$redirectListPair1(ILit/unimi/dsi/fastutil/doubles/DoubleList;Lit/unimi/dsi/fastutil/doubles/DoubleList;ZZ)Lnet/minecraft/class_255; -> Prepare ->  -> { target: method_1082(Lnet/minecraft/class_265;Lnet/minecraft/class_265;Lnet/minecraft/class_247;)Lnet/minecraft/class_265; }]

this one i couldn't understand

	Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/client/particle/Particle::optimiseParticleCollisions with priority 1000 cannot inject into net/minecraft/client/particle/Particle::move(DDD)V merged by com.modrinth.methane.mixin.ParticleMixin with priority 1200 [INJECT_PREPARE Applicator Phase -> moonrise.mixins.json:collisions.ParticleMixin from mod moonrise -> Prepare Injections -> redirect$ioa000$moonrise$optimiseParticleCollisions(Lnet/minecraft/entity/Entity;Lnet/minecraft/util/math/Vec3d;Lnet/minecraft/util/math/Box;Lnet/minecraft/world/World;Ljava/util/List;)Lnet/minecraft/util/math/Vec3d; -> Prepare ->  -> { target: move(DDD)V }]

Particle optimization if i understand correctly

  • Carpet

Which is enough for me already, I can't drop so many mods for Moonrise sadly. I really hope to see it with improved compatibility in the future! Great thing (well, sad that there's a need) that we have so many optimization mods nowadays:D

  • Architectury

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants