-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] Lag spikes in rendering thread #27
Comments
Better thread management than vanilla is already part of the mod, it reduces frame spikes when generating/loading chunks by reducing vanilla's overallocation of threads to chunk gen and background tasks (see the |
I did test the mod with just FabricAPI and ModMenu installed, which shouldn't affect anything, and I was still observing large lag spikes on the rendering thread. I also tested the mod with VulkanMod, which shouldn't modify threading in any way, to rule out lag spikes from chunk loading and a very similar behavior was observed. |
Do you still experience the same issue without moonrise…? |
No, it's only happening with Moonrise installed. |
I created three videos to better showcase the issue. The first one is just vanilla, the second one is just Moonrise and the third one is VulkanMod with Moonrise to rule out chunk loading issues. For Vanilla and VulkanMod I also used F3 + A to show the effect of chunk loading on frame time, but the beginning is a bit cut off for some reason. Vanilla.mp4Moonrise.mp4VulkanMod.Moonrise.mp4 |
Any clue what might cause this? |
Chunks aren't generated on the render thread, what jmp was referring to is bad thread management taking away processing time/threads from other things. He also made #29 to reduce light processing load |
I see, thanks for the insight. |
I'm currently creating a performance Modpack and during testing with Moonrise I noticed large lag spikes during chunk generation/loading. Taking a look at F3 + 2 profiler, I noticed that Moonrise sometimes seems to utilize the rendering and the client thread, causing stuttering.
My suggestion is to maybe blacklist the client and rendering threads to prevent this from happening.
The text was updated successfully, but these errors were encountered: