Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify assume/observe design #402

Closed
ParadaCarleton opened this issue Mar 15, 2022 · 2 comments
Closed

Simplify assume/observe design #402

ParadaCarleton opened this issue Mar 15, 2022 · 2 comments

Comments

@ParadaCarleton
Copy link
Member

Creating this issue after @yebai asked me to -- it looks to me like assume and observe could be simplified a bit.

Current thoughts:

  1. We should clearly document the differences between observe, tilde_observe, tilde_observe!!, etc.
  2. If it's possible, we could try and combine some.
  3. Make the behavior of observe, assume, etc. more similar, e.g. by having both return the same values.
@devmotion
Copy link
Member

Probably @torfjelde knows best why the current design was chosen, what could be simplified, and which changes are problematic.

@mhauru mhauru mentioned this issue Dec 5, 2024
Open
@yebai
Copy link
Member

yebai commented Dec 19, 2024

Closed in favour of TuringLang/Turing.jl#2422

@yebai yebai closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devmotion @yebai @ParadaCarleton