Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Bayesian Differential Equation" tutorial needs small improvements #292

Closed
nathanaelbosch opened this issue Apr 8, 2021 · 2 comments

Comments

@nathanaelbosch
Copy link

From: https://github.com/TuringLang/Turing.jl/edit/master/docs/_tutorials/10_BayesianDiffEq.md

The tutorial results seem to have changed since its initial writing. For example, the plot in the Data retrodiction section does not reproduce the true ODE solution "quite accurately", since there is a big mismatch between the parameters in the three chains. I suspect that to resolve this issue and fix the example, some minor parameter tweaking could already be sufficient.

@devmotion
Copy link
Member

Yes, the results should definitely be improved or one has to weaken this claim 😄

Currently, the tutorials are reorganized and moved to Julia markdown files that are easier to handle than Jupyter notebooks. You can follow the progress here: #113 It should be done soon and be based on more recent versions of Turing, MCMCChains etc. Hopefully the new structure makes it easier to keep the package versions updated and fix issues.

@devmotion
Copy link
Member

The tutorial was just updated yesterday (#296) and runs fine with the latest versions of Turing and DifferentialEquations (see https://turing.ml/dev/tutorials/10-bayesian-differential-equations/). It's part of our CI pipeline, and hence it should be easy to spot and fix regressions when e.g. updating Turing or DifferentialEquations in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants