-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript "non-standard" compiler options #1
Comments
ts-loader has an option called gulp-typescript also supports this feature but in a weird way, IMO. Instead of exposing a separate option, it uses the TypeScript option In any case, I think it's a useful feature, but I agonized over what to name it and I'm not really happy with it but didn't want to bikeshed anymore. |
I'd prefer the term This is the name used by |
Fair enough, you still point to a |
Yeah, I thought that too (see comment TypeStrong/grunt-ts#202 (comment)), but it definitely overloads the term if used in the ecosystem of other tools. I'd be okay for current tools keeping
Some hand waving here : https://github.com/basarat/tsb/tree/master and more why https://github.com/basarat/tsb/blob/master/docs/contributing/why.md ... I'll make it public (switch branches ... move to org) once there is more concrete stuff |
I think this point is really important to make sure we're even naming the same thing.
I think it makes sense to first figure out which way, if any, we would want to standardize on before we can name it. (btw, I gathered the above information in like 3 minutes so correct me if I'm wrong) |
FWIW, the reason I went with the filename only approach in ts-loader is because I was trying to keep close to |
@jbrantly Sounds correct to me. I thought with the same idea, but ended up changing to using the same behaviour as |
Grunt-ts 5 uses Grunt-ts is greedy, though. We actually parse the tsconfig.json ourselves as we do things like updating the files element. We then pass the tsconfig settings as switches. We also support a tsconfig I am willing to consolidate |
@nycdotnet Cool to hear. I've just been using https://github.com/TypeStrong/tsconfig for parsing the config file (it also does the resolving from a directory look up and populating If we're using the config filename option, I personally prefer the explicitness of |
Possibly related: microsoft/TypeScript#4883 Not merged (don't know if it will be merged) but I subscribed and if merged would certainly make sense to support supplying full paths for |
I think |
I just wanted to start by opening a discussion on the options we expose for users and see if we can pick some some common ones together. Maybe too formal and boring to get started, but bear with me.
ntypescript
)typescript
currentlytsconfig.json
configFile
, butproject
is standard and doesn't break the ecosystemconfigFileName
Please add your own and I'll keep this up to date, and once we close up I can make a module that we can re-use across the compiler repos to normalize this information 😄 Also, if you think one of the above options are wrong or incorrect, definitely point it out 👍
Edit: FWIW, this is awesome - thanks @jbrantly and @smrq for moving your repos, it looks great!
The text was updated successfully, but these errors were encountered: