Remove setup_postdata() call in ucfwp_get_excerpt()

[cjg89]

Description

UCF-WordPress-Theme/includes/utilities.php

Lines 78 to 102 in 221fc73

	function ucfwp_get_excerpt( $post, $length=0 ) {
	if ( ! ( $post instanceof WP_Post ) ) return '';
	if ( $length === 0 ) {
	$length = apply_filters( 'excerpt_length', $length );
	}
	// Allow custom excerpt modification short-circuit
	$excerpt = apply_filters( 'ucfwp_get_excerpt_before', '', $post, $length );
	if ( $excerpt ) {
	return $excerpt;
	}
	setup_postdata( $post );
	$custom_filter = function( $l ) use ( $length ) {
	return $length;
	};
	add_filter( 'excerpt_length', $custom_filter, 999 );
	$excerpt = wp_strip_all_tags( get_the_excerpt( $post ) );
	remove_filter( 'excerpt_length', $custom_filter, 999 );
	return apply_filters( 'ucfwp_get_excerpt', $excerpt, $post, $length );
	}

This setup_postdata() call in this function should not be necessary and should be removed (assuming that doing so doesn't result in breakage).

Why it's Important

This line was originally added after reading this in the documentation for get_the_excerpt(): https://developer.wordpress.org/reference/functions/get_the_excerpt/#comment-content-2457 However, this comment is out of date--as of WP 5.2, get_the_excerpt() and wp_trim_excerpt() pass along the $post variable to get_the_content() when no excerpt is defined, eliminating the need for handling global post data manually. Additionally, it doesn't look like setup_postdata() sets up a global $post object to begin with, so calling setup_postdata() is not accomplishing its intended goal anyway.

Alternatives

n/a

Possible Implementation

Remove it and test.

Additional context

n/a