Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news/"Vertical Feature" post list layout show_excerpt and excerpt_length support #121

Open
cjg89 opened this issue Dec 1, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cjg89
Copy link
Member

cjg89 commented Dec 1, 2021

Description

The UCF Post List SC plugin v2.1.0 will add support for new show_excerpt and excerpt_length shortcode attributes (see UCF/UCF-Post-List-Shortcode#38). The news layout built for this theme already utilizes its own show_excerpt attribute, and will be compatible with this update, but could be updated to support excerpt length adjustments.

Why it's Important

To reduce confusion and ensure we're supporting available shortcode attributes where appropriate.

Alternatives

n/a

Possible Implementation

  1. Update comment here: https://github.com/UCF/UCF-WordPress-Theme/blob/master/includes/post-list-functions.php#L37-L39 (note that we still need the actual attribute value override here, as the UCF Post List plugin's default for this attribute is false)
  2. Update ucfwp_post_list_display_news() to support excerpt_length attribute. https://github.com/UCF/UCF-WordPress-Theme/blob/master/includes/post-list-functions.php#L232-L237 Logic in this snippet may need to be tweaked a bit to support these existing layout-specific filters as well as UCF_Post_List_Common::get_excerpt()

Additional context

n/a

@cjg89 cjg89 added the enhancement New feature or request label Dec 1, 2021
@cjg89 cjg89 added this to the backlog milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants