Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pod] Simplify temperature reading data shape #73

Closed
taesungh opened this issue May 25, 2024 · 0 comments · Fixed by #91
Closed

[Pod] Simplify temperature reading data shape #73

taesungh opened this issue May 25, 2024 · 0 comments · Fixed by #91
Assignees

Comments

@taesungh
Copy link
Member

Following from #37/#47 and #55/#64, we made LimTemperature::read_lim_temps return a 4-tuple of temperature values, but in the FSM, we reshape that into a fixed-size array [f32; 4] to combine with a second set of measurements. The 4-tuple is initially produced from using array::map on another fixed-size array, so we could simply return that shape instead of unnecessarily reshaping twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants