Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed create account text from bottom of registration page #213

Closed
wants to merge 3 commits into from

Conversation

Tofulati
Copy link

@Tofulati Tofulati commented Sep 29, 2022

Removed link since it would link back to the same page

Fixed #212

Proposed changes

Removed the lines of code
<div className="align-x createAcc"> <p>Don't have an account?</p> <Link to="/register">Create an account</Link> </div>

Types of changes

What types of changes does your code introduce to the UC Merced's ACM Chapter Website?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

image

Further comments

There may be a better solution that doesn't remove multiple lines of code that may break the site.

Tofulati and others added 3 commits September 29, 2022 14:47
dont need create new account link on registration page

Fixed UCMercedACM#212
added spaces between submit and fields
@No767
Copy link
Member

No767 commented Aug 31, 2024

This PR is closed following an modern rewrite of the website. Probably a change I will implement later down the road, but OAuth2 is probably preferred here more than storing emails on firebase.

@No767 No767 closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature/Remove create account from bottom of registration page
2 participants