Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using the package cached-path #10

Open
apmoore1 opened this issue Nov 25, 2021 · 0 comments
Open

Move to using the package cached-path #10

apmoore1 opened this issue Nov 25, 2021 · 0 comments

Comments

@apmoore1
Copy link
Member

The AllenNLP team have created a Python package called cached-path which can replace the whole of the file_utils.py moudle as that entire module has been mainly been taken from the AllenNLP code base. The benefit of moving to this package is that it is more than likely able to handle more edge cases and any future problems, further it will mean that in this code base we will not have to maintain that one module.

The downside to using this package is that the package requires many dependencies that we currently do not use or need like:

  1. huggingface-hub
  2. google-cloud-storage
  3. boto3
  4. filelock

However in the future we may need all of these requirements, e.g. if we wish to train models with datasets from huggingface-hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant