Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MockUserService #1466

Open
NicMcPhee opened this issue Jan 22, 2024 · 0 comments
Open

Remove the MockUserService #1466

NicMcPhee opened this issue Jan 22, 2024 · 0 comments

Comments

@NicMcPhee
Copy link
Member

I think this actually adds a lot of complication, isn't used that much, and is probably the wrong tool for the job. I think that spies and stubs are a better solution and allow us to focus more clearly on what we're trying to test. We don't actually use the MockUserService much, so I think we can just get rid of it, moving the necessary stubs directly into the relevant tests.

If we do this, then I think we can also remove the | null from the constructor in UserService, and drop all the !s in that file that were added because the httpClient could be null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant