Add JSON reader & extractor #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the late response, I hadn't realised this was ready for review. Before I review this, can you add relevant documentation changes in |
|
@lukavdplas I included the json module in the mkdocs index, and updated the README to state that the package also defines a reader for JSON. I also just went ahead now and excluded the Python 3.8 test from the GitHub actions matrix, and edited the README to state that we don't support Python versions lower than 3.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6. This proved more complicated than I first envisioned, because the example data I found happened to be structured as arrays within a dictionary. This solution can now tackle both types of data: single file with multiple documents, or a file per document.
Unfortunately, the pandas libary needs to be a higher version than available with Python 3.8 to flatten the JSON appropriately. Should we drop Python 3.8 support, seeing as it's beyond end of life now?