Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with default KUBECONFIG if no other path is specified #37

Open
axisofentropy opened this issue Aug 18, 2023 · 2 comments
Open

Merge with default KUBECONFIG if no other path is specified #37

axisofentropy opened this issue Aug 18, 2023 · 2 comments
Assignees

Comments

@axisofentropy
Copy link
Member

Other Kubernetes configuration actions, including https://github.com/helm/kind-action and the k3s actions on the GHA marketplace, do write the resulting kubeconfig file to the default location .kube/config. Our action should mimic this behavior by default if users do not specify the kubeconfig input.

I think our CLI does this by default now? Check with @zipofar. Maybe we can just drop the --kubeconfig argument from uffizzi cluster create?

The goal is so workflows can follow our action with kubectl or helm without specifying --kubeconfig, as seen in documentation for other Kubernetes configuration actions.

@axisofentropy
Copy link
Member Author

Our action should also set the KUBECONFIG environment variable, either using export or using some GitHub Action facility.

@zipofar
Copy link

zipofar commented Aug 18, 2023

When we create cluster we can do not define kubeconfig flag. CLI gets path from the env KUBECONFIG or use default path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants