Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Redux or React context api #7

Open
Ujjalzaman opened this issue Nov 7, 2022 · 4 comments
Open

Implement Redux or React context api #7

Ujjalzaman opened this issue Nov 7, 2022 · 4 comments
Assignees

Comments

@Ujjalzaman
Copy link
Owner

No description provided.

@mamadou-niakate
Copy link
Contributor

mamadou-niakate commented Jan 19, 2023

Can you please assign this to me ? I can implement React Context API with useReducer instead of a useState hook for each single state.

@Ujjalzaman
Copy link
Owner Author

thank @mamadou-niakate I'm thinking update the overall website as well, looking for some contribution,
having lots of timing conflicts, and have to work on weekends.
anyway, I'm assigning you the issue.
also, you can join me by skype or email.

@mamadou-niakate
Copy link
Contributor

Hey @Ujjalzaman i implemented the Context API.
I also notice an issue: when you come on the home page there's issue with data fetching the page get overlapped by a modald with the following error:

×
Unhandled Rejection (TypeError): Failed to fetch
(anonymous function)
C:/Users/mamad/Documents/Open-source-contribution/Easy-Consulting-react/src/component/Home/Reviews/Reviews.jsx:14
  11 | SwiperCore.use([Pagination, Autoplay]);
  12 | const [reviews, setReviews] = useState([])
  13 | useEffect(() => {
> 14 |     fetch('https://immense-river-40491.herokuapp.com/reviews')
     | ^  15 |     .then(res => res.json())
  16 |     .then(data => {
  17 |         setReviews(data);

And you have to manually close that modal.

You can open a new issue i will correct it

@Ujjalzaman
Copy link
Owner Author

@mamadou-niakate Please join me on skype or email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants