From 94864d81bc0237a1cede928b9d60eb2a0996257f Mon Sep 17 00:00:00 2001 From: Daniel Gretzke Date: Wed, 16 Oct 2024 17:22:15 +0200 Subject: [PATCH] Dev (#8) * Dev (#2) * Remove default MIT license * Remove libraries Co-authored-by: Madeveda * forge install: forge-gas-snapshot * add testing info * remove versioning * add gasmetering to tests (#1) * update solidity version * add issue templates * add coverage script * add formatting rules * add RPCs --------- Co-authored-by: Madeveda * Ignore coverage report, increase coverage, adjust CI --------- Signed-off-by: Daniel Gretzke Co-authored-by: Madeveda --- script/Deploy.s.sol | 6 ++---- test/Counter.t.sol | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/script/Deploy.s.sol b/script/Deploy.s.sol index 969d949..216f766 100644 --- a/script/Deploy.s.sol +++ b/script/Deploy.s.sol @@ -8,10 +8,8 @@ import {Counter} from 'src/Counter.sol'; contract Deploy is Script { using stdJson for string; - function run() public returns (Counter counter) { - vm.startBroadcast(vm.envUint('PRIVATE_KEY')); + function run() public returns (Counter) { uint256 initialNumber = 5; - counter = new Counter(initialNumber); - vm.stopBroadcast(); + return new Counter(initialNumber); } } diff --git a/test/Counter.t.sol b/test/Counter.t.sol index 287ecc0..084b23d 100644 --- a/test/Counter.t.sol +++ b/test/Counter.t.sol @@ -43,7 +43,6 @@ contract DeploymentTest is Test { Counter counter; function setUp() public virtual { - vm.setEnv('PRIVATE_KEY', vm.toString(makeAccount('DEPLOYER').key)); counter = new Deploy().run(); }