diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f036334..ae1a37f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1,2 @@ * @uniswap/protocols +.github/workflows/ @uniswap/security \ No newline at end of file diff --git a/.github/workflows/semgrep.yml b/.github/workflows/semgrep.yml index c773069..b66798f 100644 --- a/.github/workflows/semgrep.yml +++ b/.github/workflows/semgrep.yml @@ -7,7 +7,7 @@ on: - main schedule: # random HH:MM to avoid a load spike on GitHub Actions at 00:00 - - cron: '35 11 * * *' + - cron: "35 11 * * *" jobs: semgrep: name: semgrep/ci diff --git a/.github/workflows/trufflehog.yml b/.github/workflows/trufflehog.yml index 4f15be8..75a047e 100644 --- a/.github/workflows/trufflehog.yml +++ b/.github/workflows/trufflehog.yml @@ -33,7 +33,7 @@ jobs: path: ./ base: "${{ github.event.repository.default_branch }}" head: HEAD - extra_args: --debug --only-verified + extra_args: --debug --only-verified - name: Scan Results Status if: steps.trufflehog.outcome == 'failure' diff --git a/script/Deploy.s.sol b/script/Deploy.s.sol index 969d949..216f766 100644 --- a/script/Deploy.s.sol +++ b/script/Deploy.s.sol @@ -8,10 +8,8 @@ import {Counter} from 'src/Counter.sol'; contract Deploy is Script { using stdJson for string; - function run() public returns (Counter counter) { - vm.startBroadcast(vm.envUint('PRIVATE_KEY')); + function run() public returns (Counter) { uint256 initialNumber = 5; - counter = new Counter(initialNumber); - vm.stopBroadcast(); + return new Counter(initialNumber); } } diff --git a/test/Counter.t.sol b/test/Counter.t.sol index 287ecc0..084b23d 100644 --- a/test/Counter.t.sol +++ b/test/Counter.t.sol @@ -43,7 +43,6 @@ contract DeploymentTest is Test { Counter counter; function setUp() public virtual { - vm.setEnv('PRIVATE_KEY', vm.toString(makeAccount('DEPLOYER').key)); counter = new Deploy().run(); }