Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming of JSON_RPC_PROVIDER urls to use the Chain Name instead of ChainId #56

Open
zhongeric opened this issue Jul 13, 2022 · 1 comment

Comments

@zhongeric
Copy link
Collaborator

zhongeric commented Jul 13, 2022

If the idea is to keep routing-api inline with SOR usage, the .env variables should be:

   JSON_RPC_PROVIDER_{CHAIN NAME} = { RPC Provider}
   # Ex: JSON_RPC_PROVIDER_MAINNET
   ...

It's also a lot easier to read

Also update README to remove // in example CURL req
curl --request GET '<INSERT_YOUR_URL_HERE>/quote?tokenInAddress=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2&tokenInChainId=1&tokenOutAddress=0x1f9840a85d5af5bf1d1762f925bdaddc4201f984&tokenOutChainId=1&amount=100&type=exactIn'
to
curl --request GET '<INSERT_YOUR_URL_HERE>quote?tokenInAddress=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2&tokenInChainId=1&tokenOutAddress=0x1f9840a85d5af5bf1d1762f925bdaddc4201f984&tokenOutChainId=1&amount=100&type=exactIn'

@ProtonAnwar
Copy link

Hi,
There is a problem that I am trying to figure out since 1 day, the APIs are successfully deployed on AWS. But during API calls It returns an internal server error in response. I followed the steps in the documentation which is connected to an AWS account and it deployed successfully.
If i change the JSON_RPC_PROVIDER_{CHAIN ID} = { RPC Provider} with JSON_RPC_PROVIDER_{CHAIN NAME} = { RPC Provider} so it does not effect on the code.
Can you help me to understand the AWS arn to how to add key value credential in secret manager arn and also how to rpc add in env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants