From e4e1e08c13d391585177883604ca50bbbfc35768 Mon Sep 17 00:00:00 2001 From: three9s <156545083+three9s@users.noreply.github.com> Date: Sun, 20 Oct 2024 09:30:44 -0700 Subject: [PATCH 1/2] fix: explicitly mark visibility of state for actions constants --- src/libraries/Actions.sol | 44 +++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/libraries/Actions.sol b/src/libraries/Actions.sol index 49d3e04f..b3f8fbb8 100644 --- a/src/libraries/Actions.sol +++ b/src/libraries/Actions.sol @@ -6,35 +6,35 @@ pragma solidity ^0.8.0; library Actions { // pool actions // liquidity actions - uint256 constant INCREASE_LIQUIDITY = 0x00; - uint256 constant DECREASE_LIQUIDITY = 0x01; - uint256 constant MINT_POSITION = 0x02; - uint256 constant BURN_POSITION = 0x03; + uint256 internal constant INCREASE_LIQUIDITY = 0x00; + uint256 internal constant DECREASE_LIQUIDITY = 0x01; + uint256 internal constant MINT_POSITION = 0x02; + uint256 internal constant BURN_POSITION = 0x03; // swapping - uint256 constant SWAP_EXACT_IN_SINGLE = 0x04; - uint256 constant SWAP_EXACT_IN = 0x05; - uint256 constant SWAP_EXACT_OUT_SINGLE = 0x06; - uint256 constant SWAP_EXACT_OUT = 0x07; + uint256 internal constant SWAP_EXACT_IN_SINGLE = 0x04; + uint256 internal constant SWAP_EXACT_IN = 0x05; + uint256 internal constant SWAP_EXACT_OUT_SINGLE = 0x06; + uint256 internal constant SWAP_EXACT_OUT = 0x07; // donate - uint256 constant DONATE = 0x08; + uint256 internal constant DONATE = 0x08; // closing deltas on the pool manager // settling - uint256 constant SETTLE = 0x09; - uint256 constant SETTLE_ALL = 0x10; - uint256 constant SETTLE_PAIR = 0x11; + uint256 internal constant SETTLE = 0x09; + uint256 internal constant SETTLE_ALL = 0x10; + uint256 internal constant SETTLE_PAIR = 0x11; // taking - uint256 constant TAKE = 0x12; - uint256 constant TAKE_ALL = 0x13; - uint256 constant TAKE_PORTION = 0x14; - uint256 constant TAKE_PAIR = 0x15; + uint256 internal constant TAKE = 0x12; + uint256 internal constant TAKE_ALL = 0x13; + uint256 internal constant TAKE_PORTION = 0x14; + uint256 internal constant TAKE_PAIR = 0x15; - uint256 constant SETTLE_TAKE_PAIR = 0x16; - uint256 constant CLOSE_CURRENCY = 0x17; - uint256 constant CLEAR_OR_TAKE = 0x18; - uint256 constant SWEEP = 0x19; + uint256 internal constant SETTLE_TAKE_PAIR = 0x16; + uint256 internal constant CLOSE_CURRENCY = 0x17; + uint256 internal constant CLEAR_OR_TAKE = 0x18; + uint256 internal constant SWEEP = 0x19; // minting/burning 6909s to close deltas - uint256 constant MINT_6909 = 0x20; - uint256 constant BURN_6909 = 0x21; + uint256 internal constant MINT_6909 = 0x20; + uint256 internal constant BURN_6909 = 0x21; } From 6cae9e2f2905d8d863ec59a7f90888ce904dcbb9 Mon Sep 17 00:00:00 2001 From: three9s <156545083+three9s@users.noreply.github.com> Date: Sat, 7 Dec 2024 08:14:10 -0800 Subject: [PATCH 2/2] Update Actions.sol --- src/libraries/Actions.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/Actions.sol b/src/libraries/Actions.sol index 3da4ebfc..a33c4e87 100644 --- a/src/libraries/Actions.sol +++ b/src/libraries/Actions.sol @@ -46,4 +46,4 @@ library Actions { // note this is not supported in the position manager or router uint256 internal constant MINT_6909 = 0x17; uint256 internal constant BURN_6909 = 0x18; -} \ No newline at end of file +}