Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused config.xml sections #247

Open
dbellettini opened this issue Jan 13, 2013 · 1 comment
Open

Remove unused config.xml sections #247

dbellettini opened this issue Jan 13, 2013 · 1 comment
Labels
technical story

Comments

@dbellettini
Copy link
Member

Just keep commands settings.

Classes using appSettings

  • AntiVirusFactory
  • FileAdd
  • FileDownload
  • FileStudentiAdd
  • FrontController
  • NewsAdd
  • ScriptCancelUser
  • ScriptCreaCatalogoFIle
  • ScriptUpdateFileHash
  • ShowCdl
  • ShowCollaboratore
  • ShowContacts
  • ShowContattoDocente
  • ShowContribute
  • ShowFacolta
  • ShowRules
  • UniversiboCommand

Parameter which should moved elsewhere

  • alertMessage
  • catalogoFileName
  • contattoDocentiAdmin
  • defaultAnnoAccademico
  • infoEmail
  • modFileStudenti
  • rootEmail
  • questionariReceiver
  • staffEmail

Parameters which should be kept, hard-coded or computed

  • contactsPath
  • filesPath
  • rootUrl
@ghost ghost assigned dbellettini Jan 13, 2013
dbellettini added a commit that referenced this issue Feb 8, 2013
@dbellettini
Removing unused rootFolder section #247
7a46a49
dbellettini added a commit that referenced this issue Feb 8, 2013
@dbellettini
Removing unused rootFolder section from config.xml #247
1d3872d
dbellettini added a commit that referenced this issue Feb 8, 2013
@dbellettini
Cleaning up colde #247
c04d391
@dbellettini
Copy link
Member Author

appSettings should be removed too by moving settings to app/config/parameters.ini
Finally file should be moved to src/Universibo/Bundle/LegacyBundle/Resources/config/legacy.xml

@dbellettini dbellettini reopened this Feb 9, 2013
dbellettini added a commit that referenced this issue Feb 10, 2013
@dbellettini
Removing Antivirus from config.xml #247
0d2fed6
dbellettini added a commit that referenced this issue Feb 10, 2013
@dbellettini
Removing unused config sections #247
602cefa
dbellettini added a commit that referenced this issue Feb 10, 2013
@dbellettini
Moving alertMessage to parameters.yml, needed for #247 and #258
18e256f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbellettini