Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config for enabling Prometheus #7

Open
Fabio1988 opened this issue Nov 20, 2023 · 3 comments
Open

Config for enabling Prometheus #7

Fabio1988 opened this issue Nov 20, 2023 · 3 comments

Comments

@Fabio1988
Copy link
Contributor

To align with Dragonite/Golbat
@lenisko
Copy link
Contributor

lenisko commented Dec 1, 2023

@Fabio1988 I see no point in that. It would overcomplicate things much more than it's required. Feel free to implement if you want though.

-- JS hater.

@lenisko lenisko removed their assignment Dec 1, 2023
@Fabio1988
Copy link
Contributor Author

I only remember comstud implementing a "non-op" prometheus integration for Golbat Not sure if it's worth and ever possible with Rotom. This came up when #9 happened and broke same set-ups :)

@lenisko
Copy link
Contributor

lenisko commented Dec 1, 2023

It's a matter of adding a switch, but it makes literally no sense to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lenisko @Fabio1988