From 5ff644619b2ca9d7196034c8a676c7685e71374a Mon Sep 17 00:00:00 2001
From: Finn Wilkinson <finnwilkinson5@gmail.com>
Date: Tue, 10 Dec 2024 12:11:14 +0000
Subject: [PATCH] Attended PR comments.

---
 CMakeLists.txt                                 | 3 +--
 src/include/simeng/arch/aarch64/Instruction.hh | 7 ++++---
 src/include/simeng/arch/aarch64/helpers/sve.hh | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bb7175920..a0e36fb91 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -157,8 +157,7 @@ if(SIMENG_ENABLE_TESTS)
       # Print message containing if the full test suite will run
     if (${LLVM_PACKAGE_VERSION} VERSION_LESS "14.0")
       message(STATUS "LLVM version does not support AArch64 extensions SVE2, SVE2.1, SME, or SME2. Related tests will fail.")
-    endif()
-    if (${LLVM_PACKAGE_VERSION} VERSION_LESS "18.0")
+    elseif (${LLVM_PACKAGE_VERSION} VERSION_LESS "18.0")
       message(STATUS "LLVM version does not support AArch64 extensions SME2 or SVE2.1. Related test will fail.")
     endif()
 
diff --git a/src/include/simeng/arch/aarch64/Instruction.hh b/src/include/simeng/arch/aarch64/Instruction.hh
index f3854c84b..6db73f0e6 100644
--- a/src/include/simeng/arch/aarch64/Instruction.hh
+++ b/src/include/simeng/arch/aarch64/Instruction.hh
@@ -306,9 +306,10 @@ std::vector<std::array<uint64_t, 4>> predAsCounterToMasks(
     for (int i = 0; i < elemsPerVec; i++) {
       // Move bit to next position based on element type
       uint64_t shifted_active = 1ull << ((i % (64 / sizeof(T))) * sizeof(T));
-      // If invert = 1, predElemCount dictates number of initial inactive
-      // elements.
-      // If invert = 0, it is number of initial active elements.
+      // If invert = True (invert bit = 1), predElemCount dictates number of
+      // initial inactive elements.
+      // If invert = False (invert bit = 0), it indicates the number of initial
+      // active elements.
       if ((r * elemsPerVec) + i < predElemCount) {
         out[r][i / (64 / sizeof(T))] |= (invert) ? 0 : shifted_active;
       } else {
diff --git a/src/include/simeng/arch/aarch64/helpers/sve.hh b/src/include/simeng/arch/aarch64/helpers/sve.hh
index 50eb19c65..a42bd9680 100644
--- a/src/include/simeng/arch/aarch64/helpers/sve.hh
+++ b/src/include/simeng/arch/aarch64/helpers/sve.hh
@@ -626,7 +626,7 @@ std::enable_if_t<std::is_floating_point_v<T>, RegisterValue> sveFDivPredicated(
   return {out, 256};
 }
 
-/** Helpfer function for SVE instructions with the format `faddv rd, pg, zn.
+/** Helper function for SVE instructions with the format `faddv rd, pg, zn.
  * D represents the source vector element type and the destination scalar
  * register type (i.e. for zn.s and sd, D = float).
  * Returns correctly formatted RegisterValue. */