Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: encoding/decoding of covenants #14

Open
kilpatty opened this issue Jul 22, 2019 · 0 comments
Open

tests: encoding/decoding of covenants #14

kilpatty opened this issue Jul 22, 2019 · 0 comments

Comments

@kilpatty
Copy link
Member

We have all of the encoding and decoding implemented for covenants, but due to the differences between rsd and hsd, it's super important that we have tests to ensure that we are properly encoding and decoding these types.

It's also very important for us to implement some edge cases in these scenarios. We should be testing scenarios in which the size of what we are encoding goes above the usual "varint" max before it adds a prefix (252 I believe). That way we can ensure that we are properly using that type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant