Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDA-5946 - Modified form group with Yoda buttons to stick to the top of metadata form. #369

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

kaur16
Copy link
Contributor

@kaur16 kaur16 commented Oct 8, 2024

YDA-5946 - Modified form group with Yoda buttons to stick to the top of metadata form.

@kaur16 kaur16 requested a review from lwesterhof October 8, 2024 11:26
@kaur16
Copy link
Contributor Author

kaur16 commented Oct 18, 2024

Let me know what you think about this!

research/metadata-form/src/index.js Outdated Show resolved Hide resolved
@@ -606,9 +629,6 @@ class Container extends React.Component {
deleteMetadata={deleteMetadata}
cloneMetadata={this.cloneMetadata} />
<YodaForm ref={(form) => {this.form=form;}}/>
<YodaButtons saveMetadata={this.saveMetadata}
deleteMetadata={deleteMetadata}
cloneMetadata={this.cloneMetadata} />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can pull the card header and card body into this render statement.

Then it should look something like this:
Screenshot 2024-10-21 at 08-49-48 Yoda - Dev - Research

…sion of grid for long folder names in vault space. Added dynamic css for top attribute of card header if maintenance banner is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants