Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCOPE Buffer size too small #144

Open
katef opened this issue Mar 21, 2022 · 0 comments
Open

SCOPE Buffer size too small #144

katef opened this issue Mar 21, 2022 · 0 comments

Comments

@katef
Copy link

katef commented Mar 21, 2022

Hiya! I've been playing with using the scope in XY mode to display text, and I'm hitting against what I think is the hardcoded BUFFER_SIZE limit here:
https://github.com/VCVRack/Fundamental/blob/v2/src/Scope.cpp#L5

Here's about as much detail as I'm able to show before it breaks down:
image

(this is supposed to be a 5x5 grid of the letter "A", but most of them aren't being drawn)

after this, if I turn up the resolution for my inputs, the scope sort of mysteriously gives up and shows simplified waveforms (the ones in my images are already being cut down I think).

or here, I was trying to render high-frequency blocks for each pixel in the grid, where the lissajous patterns are, to make a sort of solid block. But I was only able to get the density you see here, before the scope gave up:
image

I think both of these are due to the buffer size.

I'd make a PR to bump this to 1024 or so, but CONTRIBUTING.md says not to, and I'm sure you'd want to check that whatever larger value is fine for performance and such.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant