Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: pr7736 in v6 #7902

Merged
merged 1 commit into from
Nov 6, 2024
Merged

patch: pr7736 in v6 #7902

merged 1 commit into from
Nov 6, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov
feat(Calendar): add doneButtonShow, doneButtonDisabled props flags (#…
720224e 
…7736)

* feat(Calendar): add doneButtonShow, doneButtonDisabled props flags

* test(Calendar): add screenshots

* test(Calendar): update screenshots

* test(Calendar): update screenshots

* fix(CalendarTime): fix formatting

(cherry picked from commit 5775640)
@EldarMuhamethanov EldarMuhamethanov self-assigned this Nov 5, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 5, 2024 14:12
@EldarMuhamethanov EldarMuhamethanov changed the title patch: pr7736 patch: pr7736 in v6 Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size
JS 385.22 KB (+0.06% 🔺)
JS (gzip) 116.46 KB (+0.06% 🔺)
JS (brotli) 95.58 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 331.15 KB (+0.02% 🔺)
CSS (gzip) 41.35 KB (+0.04% 🔺)
CSS (brotli) 32.69 KB (-0.07% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👀 Docs deployed

Commit 720224e

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (66405d2) to head (720224e).
Report is 16 commits behind head on v6.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #7902      +/-   ##
==========================================
- Coverage   95.20%   95.18%   -0.02%     
==========================================
  Files         383      383              
  Lines       11340    11349       +9     
  Branches     3723     3736      +13     
==========================================
+ Hits        10796    10803       +7     
- Misses        544      546       +2
Flag Coverage Δ
unittests 95.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit a8f0e1a into v6 Nov 6, 2024
27 of 28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the patch/pr7736-v6 branch November 6, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
None yet
Projects
VKUI
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk