Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move most of string functions into runtime-common/stdlib #1130

Merged
merged 14 commits into from
Nov 1, 2024

Conversation

apolyakov
Copy link
Contributor

No description provided.

@apolyakov apolyakov changed the title Move most of string function into runtime-common/stdlib Move most of string functions into runtime-common/stdlib Oct 26, 2024
@apolyakov apolyakov force-pushed the apolyakov/common-string-stdlib branch 4 times, most recently from 080caa3 to b9de672 Compare October 28, 2024 14:50
@apolyakov apolyakov self-assigned this Oct 29, 2024
@apolyakov apolyakov added runtime Feature related to runtime k2 k2 related labels Oct 29, 2024
@apolyakov apolyakov added this to the next milestone Oct 29, 2024
@apolyakov apolyakov marked this pull request as ready for review October 29, 2024 09:13
@astrophysik
Copy link
Contributor

Okay, but this pr breaks git history. That isn't necessary as for me

@apolyakov apolyakov force-pushed the apolyakov/common-string-stdlib branch from eff369e to 0e15b71 Compare November 1, 2024 11:26
Copy link
Contributor

@DrDet DrDet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apolyakov apolyakov merged commit 791f442 into master Nov 1, 2024
5 checks passed
@apolyakov apolyakov deleted the apolyakov/common-string-stdlib branch November 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k2 k2 related runtime Feature related to runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants