Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XnatCheckLogin #440

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Update XnatCheckLogin #440

merged 1 commit into from
Mar 21, 2024

Conversation

duettwe
Copy link
Contributor

@duettwe duettwe commented Mar 21, 2024

Would this be good enough or do we want to have more distinct error checking?

@duettwe duettwe requested a review from baxpr March 21, 2024 14:41
@duettwe
Copy link
Contributor Author

duettwe commented Mar 21, 2024

This is in reference to issue #439

baxpr
baxpr approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@baxpr baxpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@duettwe duettwe merged commit 1753694 into main Mar 21, 2024
@duettwe duettwe deleted the duettwe-xnatchecklogin-error-update branch March 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baxpr baxpr baxpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duettwe @baxpr