Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging library to properly capture errors #111

Open
chrisahardie opened this issue Jun 3, 2021 · 2 comments
Open

Add logging library to properly capture errors #111

chrisahardie opened this issue Jun 3, 2021 · 2 comments

Comments

@chrisahardie
Copy link
Collaborator

Introduce winston for logging, will stop console messages from being emitted during test runs!

@jennygrahamjones
Copy link
Collaborator

Is the intention to make wider use of the logging, or just to suppress the console messages during tests? If the latter, the --silent flag could be added to the test command.

@chrisahardie
Copy link
Collaborator Author

@jennygrahamjones The optimal solution would have been to leverage Winston and vary its transports by environment, with our non-dev environments writing logs out to an external provider like Sentry, Bugsnag, or something similar. The console error messages being suppressed would have just been a small bonus.

If you want to add a --silent flag, that would be fine. I don't anticipate we'll stand up remote logging (though it would be useful if we ever wanted to platform FYI @picuron ... )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants