-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filtered funnels do not work when there is a fan affecting the item #867
Comments
@@ -116,10 +116,11 @@ public abstract class MixinEntity implements IEntityDraggingInformationProvider
deltaMovement.y,
deltaMovement.z
- collisionResponseHorizontalNormal.z() * parallelHorizontalVelocityComponent
);
}
+ tryCheckInsideBlocks();
// Cancel the original invocation of Entity.setVelocity(DDD)V to remove vanilla behavior
callbackInfo.cancel();
}
// endregion
@@ -224,10 +225,13 @@ public abstract class MixinEntity implements IEntityDraggingInformationProvider
public abstract AABB getBoundingBox();
@Shadow
public abstract void setDeltaMovement(double x, double y, double z);
+ @Shadow
+ protected abstract void tryCheckInsideBlocks();
+
@Shadow
protected abstract Vec3 collide(Vec3 vec3d);
@Shadow
public abstract Vec3 getDeltaMovement(); may fix this |
Fixed in #955 |
Hey I'm not very experienced with javascript of any sorts. Ive been experiencing this same issue and just wanted to ask where or how to implement the fix posted by the person above |
Your best bet is waiting for the release, otherwise find the beta.5 release tag, replace common/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinEntity.java with https://github.com/MoePus/Valkyrien-Skies-2/blob/0a0418f0db33ab37745e2fbf86ab2b1e2e98a182/common/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinEntity.java, and build it |
This issue occurs when only Valkyrien Skies and addons are installed and no other mods
Minecraft Version
1.20.x
Mod Loader
Fabric
Issue description
i have been notified that this was a known issue with VS2.
Issue reproduction
use VS2 as well as any farm that involves the use of the encased fan.
Logs
No response
The text was updated successfully, but these errors were encountered: