Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtered funnels do not work when there is a fan affecting the item #867

Closed
1 task done
Zekrom7000 opened this issue Jun 7, 2024 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@Zekrom7000
Copy link

Zekrom7000 commented Jun 7, 2024

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

  • I have tested this issue and it occurs when no other mods are installed

Minecraft Version

1.20.x

Mod Loader

Fabric

Issue description

i have been notified that this was a known issue with VS2.

Issue reproduction

use VS2 as well as any farm that involves the use of the encased fan.

Logs

No response

@MoePus
Copy link
Contributor

MoePus commented Sep 2, 2024

@@ -116,10 +116,11 @@ public abstract class MixinEntity implements IEntityDraggingInformationProvider
                 deltaMovement.y,
                 deltaMovement.z
                     - collisionResponseHorizontalNormal.z() * parallelHorizontalVelocityComponent
             );
         }
+        tryCheckInsideBlocks();
         // Cancel the original invocation of Entity.setVelocity(DDD)V to remove vanilla behavior
         callbackInfo.cancel();
     }
 
     // endregion
@@ -224,10 +225,13 @@ public abstract class MixinEntity implements IEntityDraggingInformationProvider
     public abstract AABB getBoundingBox();
 
     @Shadow
     public abstract void setDeltaMovement(double x, double y, double z);
 
+    @Shadow
+    protected abstract void tryCheckInsideBlocks();
+
     @Shadow
     protected abstract Vec3 collide(Vec3 vec3d);
 
     @Shadow
     public abstract Vec3 getDeltaMovement();

may fix this

MoePus added a commit to MoePus/Valkyrien-Skies-2 that referenced this issue Sep 4, 2024
@thetheaplant
Copy link

Fixed in #955

@BigManIndian
Copy link

Hey I'm not very experienced with javascript of any sorts. Ive been experiencing this same issue and just wanted to ask where or how to implement the fix posted by the person above

@thetheaplant
Copy link

Your best bet is waiting for the release, otherwise find the beta.5 release tag, replace common/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinEntity.java with https://github.com/MoePus/Valkyrien-Skies-2/blob/0a0418f0db33ab37745e2fbf86ab2b1e2e98a182/common/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinEntity.java, and build it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants