Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Collision bugs and possible way to fix it #500

Open
Ranpoes opened this issue May 20, 2021 · 0 comments
Open

Collision bugs and possible way to fix it #500

Ranpoes opened this issue May 20, 2021 · 0 comments

Comments

@Ranpoes
Copy link

Ranpoes commented May 20, 2021

As the picture shows , the collision may detect the block under the ground without any blocks' connection and made them as one BIG ship (combining the water, lava, blocks form other mods, etc) .
Its quite common to happen in the server when there are lots of entities (especially with many players around the ship), which cause the low TPS.
2021-05-16_20 08 01
2021-05-16_20 08 32

I just add the limitation of the Y-axis in the implement of .class tryExpanding and it seems to work fine, which let the blocks under 58 can't be constructed.

protected void tryExpanding(int x, int y, int z, int hash) { if (isValidExpansion(x, y, z) && y > 58) { // totalCalls++; if (!foundSet.contains(hash) && (foundSet.size() + nextQueue.size() < maxSize)) { nextQueue.add(hash); } } }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant