Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication.java not instantiating httpClient #52

Open
zardojunior opened this issue Jun 13, 2017 · 5 comments
Open

Communication.java not instantiating httpClient #52

zardojunior opened this issue Jun 13, 2017 · 5 comments
Assignees

Comments

@zardojunior
Copy link

Hi all!
I found a problem in Communication.java class, version 11.X. If the protocols is not null, the class httpClient will never be instantiated. Maybe you should remove the first "if" statement since it is already been done (and handled) in the next lines of code.

public Communication() {
    try {
    if (getBestProtocol(SSLContext.getDefault().getDefaultSSLParameters().getProtocols()) == null) {
        String protocol = getBestProtocol(SSLContext.getDefault().getSupportedSSLParameters().getProtocols());
        if (protocol == null) {
            throw new IllegalStateException("No supported TLS protocols available");
        }
...
@zardojunior
Copy link
Author

When the fix will be released? Tks

@brianarnold789
Copy link
Member

New release will be out by the end of the week (07/28/17)

@zardojunior
Copy link
Author

@brianarnold789 Ok. Waiting.. ;-)
Thanks.

@brianarnold789
Copy link
Member

@zardojunior
I apologize for the delay, a new release is available now GitHub and Maven

@zardojunior
Copy link
Author

zardojunior commented Aug 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants